Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance shutdown behavior retrieval #18880

Merged
merged 9 commits into from
Apr 17, 2021

Conversation

eliecharra
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18618

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSInstance_basic -timeout 180m
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_basic (134.73s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       134.791s

@eliecharra eliecharra requested a review from a team as a code owner April 15, 2021 10:21
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 15, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @eliecharra 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 17, 2021
@ghost ghost removed size/M Managed by automation to categorize the size of a PR. labels Apr 17, 2021
@ghost ghost added size/L Managed by automation to categorize the size of a PR. labels Apr 17, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Output of acceptance tests (us-west-2):

--- PASS: TestAccAWSInstance_addSecondaryInterface (192.44s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (215.97s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (119.80s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (130.86s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (119.12s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (110.12s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (120.05s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (98.73s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (105.36s)
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (200.73s)
--- PASS: TestAccAWSInstance_basic (85.47s)
--- PASS: TestAccAWSInstance_blockDevices (106.37s)
--- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (135.76s)
--- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (166.40s)
--- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (198.11s)
--- PASS: TestAccAWSInstance_changeInstanceType (198.16s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (119.39s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (112.37s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (116.35s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (229.87s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (92.04s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (114.22s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (138.85s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (156.49s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (103.18s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (140.46s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (160.10s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (346.41s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (112.76s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (83.54s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (173.85s)
--- PASS: TestAccAWSInstance_dedicatedInstance (115.83s)
--- PASS: TestAccAWSInstance_disableApiTermination (165.18s)
--- PASS: TestAccAWSInstance_disappears (198.94s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (8.04s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (8.81s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (80.38s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (122.40s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (177.36s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (104.93s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (148.00s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (135.99s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (156.53s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (150.30s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (126.08s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (119.81s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (169.48s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (218.95s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (95.15s)
--- PASS: TestAccAWSInstance_enclaveOptions (178.58s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (179.51s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (197.88s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (234.23s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (79.94s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (9.80s)
--- PASS: TestAccAWSInstance_GP3RootBlockDevice (113.74s)
--- PASS: TestAccAWSInstance_hibernation (274.71s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (95.30s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (114.70s)
--- PASS: TestAccAWSInstance_inEc2Classic (120.73s)
--- PASS: TestAccAWSInstance_instanceProfileChange (240.40s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (104.39s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (115.24s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (17.94s)
--- PASS: TestAccAWSInstance_keyPairCheck (95.48s)
--- PASS: TestAccAWSInstance_metadataOptions (151.23s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (168.49s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (124.31s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (144.56s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (123.12s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (172.79s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (123.29s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (182.21s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (240.31s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (88.09s)
--- PASS: TestAccAWSInstance_placementGroup (128.96s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (130.65s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (144.99s)
--- PASS: TestAccAWSInstance_privateIP (105.89s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (101.81s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (85.77s)
--- PASS: TestAccAWSInstance_rootInstanceStore (112.60s)
--- PASS: TestAccAWSInstance_sourceDestCheck (173.17s)
--- PASS: TestAccAWSInstance_tags (117.51s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (138.56s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (128.84s)
--- PASS: TestAccAWSInstance_userDataBase64 (168.94s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (107.47s)
--- PASS: TestAccAWSInstance_withIamInstanceProfilePath (126.28s)
--- SKIP: TestAccAWSInstance_outpost (0.64s)

Output of acceptance tests (GovCloud):

--- PASS: TestAccAWSInstance_addSecondaryInterface (207.84s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (195.69s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (109.32s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (134.04s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (116.58s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (133.80s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (116.28s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (117.03s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (108.36s)
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (163.55s)
--- PASS: TestAccAWSInstance_basic (253.34s)
--- PASS: TestAccAWSInstance_basic (78.46s)
--- PASS: TestAccAWSInstance_blockDevices (109.99s)
--- PASS: TestAccAWSInstance_blockDeviceTags_ebsAndRoot (149.40s)
--- PASS: TestAccAWSInstance_blockDeviceTags_volumeTags (173.65s)
--- PASS: TestAccAWSInstance_blockDeviceTags_withAttachedVolume (222.79s)
--- PASS: TestAccAWSInstance_changeInstanceType (173.98s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (115.60s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (96.75s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (123.01s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (202.71s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (115.32s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (126.40s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (121.78s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (167.84s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (116.85s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (114.83s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (157.52s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (125.58s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (125.82s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (76.35s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (192.98s)
--- PASS: TestAccAWSInstance_disableApiTermination (156.03s)
--- PASS: TestAccAWSInstance_disappears (158.72s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (10.47s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidThroughputForVolumeType (10.58s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (125.05s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (104.57s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (172.54s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (141.29s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (162.25s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (151.86s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyThroughput_Gp3 (153.40s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (140.80s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (146.57s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (161.42s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (229.93s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (98.60s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (171.96s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (224.97s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (206.67s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (88.69s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (10.78s)
--- PASS: TestAccAWSInstance_GP3RootBlockDevice (100.39s)
--- PASS: TestAccAWSInstance_hibernation (239.85s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (89.23s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (100.53s)
--- PASS: TestAccAWSInstance_instanceProfileChange (227.79s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (106.94s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (108.86s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (21.13s)
--- PASS: TestAccAWSInstance_keyPairCheck (95.64s)
--- PASS: TestAccAWSInstance_metadataOptions (169.60s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (127.27s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (134.37s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (124.73s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (115.88s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (201.75s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (103.17s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (183.69s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (241.17s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (99.17s)
--- PASS: TestAccAWSInstance_placementGroup (109.77s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (137.34s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (149.97s)
--- PASS: TestAccAWSInstance_privateIP (109.20s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (118.38s)
--- PASS: TestAccAWSInstance_rootInstanceStore (105.66s)
--- PASS: TestAccAWSInstance_sourceDestCheck (180.39s)
--- PASS: TestAccAWSInstance_tags (132.49s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (143.21s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (130.06s)
--- PASS: TestAccAWSInstance_userDataBase64 (119.08s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (109.25s)
--- PASS: TestAccAWSInstance_withIamInstanceProfilePath (105.17s)
--- SKIP: TestAccAWSInstance_dedicatedInstance (19.57s)
--- SKIP: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (17.09s)
--- SKIP: TestAccAWSInstance_enclaveOptions (18.26s)
--- SKIP: TestAccAWSInstance_inEc2Classic (1.01s)
--- SKIP: TestAccAWSInstance_outpost (0.64s)
--- SKIP: TestAccAWSInstance_rootBlockDeviceMismatch (0.00s)

@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2021
@YakDriver YakDriver added this to the v3.38.0 milestone Apr 17, 2021
@YakDriver YakDriver merged commit 068ebd8 into hashicorp:main Apr 17, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instance_initiated_shutdown_behavior field is not handled by the provider
2 participants