ConnectionProperties should be optional to create glue connection

[no-brand]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19374

Release note for CHANGELOG:

resource/aws_glue_connection: ConnectionProperties to be opional (especially for network type of glue connection)

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection_Network'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_Network -timeout 180m
=== RUN   TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== CONT  TestAccAWSGlueConnection_Network
--- PASS: TestAccAWSGlueConnection_Network (60.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       60.494s

[github-actions]

Welcome @no-brand 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[DrFaust92]

LGTM

--- PASS: TestAccAWSGlueConnection_disappears (29.69s)
--- PASS: TestAccAWSGlueConnection_Kafka (39.85s)
--- PASS: TestAccAWSGlueConnection_MongoDB (41.00s)
--- PASS: TestAccAWSGlueConnection_basic (44.37s)
--- PASS: TestAccAWSGlueConnection_Description (64.12s)
--- PASS: TestAccAWSGlueConnection_Network (81.38s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (99.45s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (609.25s)

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection_'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_ -timeout 180m
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_MatchCriteria
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_Network
=== CONT  TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_Kafka
--- PASS: TestAccAWSGlueConnection_disappears (16.52s)
--- PASS: TestAccAWSGlueConnection_MongoDB (22.44s)
--- PASS: TestAccAWSGlueConnection_Kafka (22.44s)
--- PASS: TestAccAWSGlueConnection_basic (22.47s)
--- PASS: TestAccAWSGlueConnection_Description (32.11s)
--- PASS: TestAccAWSGlueConnection_Network (33.33s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (40.45s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (686.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	689.804s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_ -timeout 180m
=== RUN   TestAccAWSGlueConnection_basic
=== PAUSE TestAccAWSGlueConnection_basic
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== RUN   TestAccAWSGlueConnection_Kafka
=== PAUSE TestAccAWSGlueConnection_Kafka
=== RUN   TestAccAWSGlueConnection_Network
=== PAUSE TestAccAWSGlueConnection_Network
=== RUN   TestAccAWSGlueConnection_Description
=== PAUSE TestAccAWSGlueConnection_Description
=== RUN   TestAccAWSGlueConnection_MatchCriteria
=== PAUSE TestAccAWSGlueConnection_MatchCriteria
=== RUN   TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== PAUSE TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== RUN   TestAccAWSGlueConnection_disappears
=== PAUSE TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_basic
=== CONT  TestAccAWSGlueConnection_MatchCriteria
=== CONT  TestAccAWSGlueConnection_PhysicalConnectionRequirements
=== CONT  TestAccAWSGlueConnection_Network
=== CONT  TestAccAWSGlueConnection_Description
=== CONT  TestAccAWSGlueConnection_disappears
=== CONT  TestAccAWSGlueConnection_Kafka
=== CONT  TestAccAWSGlueConnection_MongoDB
--- PASS: TestAccAWSGlueConnection_disappears (18.54s)
--- PASS: TestAccAWSGlueConnection_basic (22.62s)
--- PASS: TestAccAWSGlueConnection_MongoDB (24.54s)
--- PASS: TestAccAWSGlueConnection_Kafka (24.59s)
--- PASS: TestAccAWSGlueConnection_Description (36.40s)
--- PASS: TestAccAWSGlueConnection_Network (36.47s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (47.87s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (687.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	693.317s

[ghost]

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.