Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust AWS Glue triggers default timeouts to be aligned with documentation #19827

Merged
merged 4 commits into from Jun 16, 2021

Conversation

slavokx
Copy link
Contributor

@slavokx slavokx commented Jun 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Description

Simple adjustment to change default timeouts for Create and Delete operations for AWS Glue triggers

Relates #19826

Output from acceptance testing:

 make testacc TESTARGS='-run=TestAccAWSGlueTrigger'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger -timeout 180m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_onDemandDisable
=== PAUSE TestAccAWSGlueTrigger_onDemandDisable
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_onDemandDisable
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Tags
=== CONT  TestAccAWSGlueTrigger_actions_notify
=== CONT  TestAccAWSGlueTrigger_Crawler
=== CONT  TestAccAWSGlueTrigger_Description
--- PASS: TestAccAWSGlueTrigger_WorkflowName (99.40s)
--- PASS: TestAccAWSGlueTrigger_disappears (100.59s)
--- PASS: TestAccAWSGlueTrigger_basic (104.67s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (109.35s)
--- PASS: TestAccAWSGlueTrigger_Description (168.75s)
--- PASS: TestAccAWSGlueTrigger_Schedule (193.65s)
--- PASS: TestAccAWSGlueTrigger_Predicate (196.07s)
--- PASS: TestAccAWSGlueTrigger_Crawler (227.06s)
--- PASS: TestAccAWSGlueTrigger_onDemandDisable (240.18s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (248.73s)
--- PASS: TestAccAWSGlueTrigger_Tags (263.17s)
--- PASS: TestAccAWSGlueTrigger_Enabled (264.24s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       264.314s


...

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2021
@slavokx slavokx marked this pull request as ready for review June 16, 2021 09:57
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @slavokx 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 16, 2021
@ewbankkit
Copy link
Contributor

@slavokx Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 357558a into hashicorp:main Jun 16, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 16, 2021
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants