Add support for additional kinesis_settings to dms_endpoint

[ksagle77]

Closes #20083

Output from acceptance testing:

I am not very familiar with go and am not sure what changes this requires to resource_aws_dms_endpoint_test.go. I'm unable to test it myself, but if this looks correct I will commit it:

func TestAccAwsDmsEndpoint_Kinesis(t *testing.T) {
	resourceName := "aws_dms_endpoint.dms_endpoint"
	randId := acctest.RandString(8) + "-kinesis"

	resource.ParallelTest(t, resource.TestCase{
		PreCheck:     func() { testAccPreCheck(t) },
		ErrorCheck:   testAccErrorCheck(t, dms.EndpointsID),
		Providers:    testAccProviders,
		CheckDestroy: dmsEndpointDestroy,
		Steps: []resource.TestStep{
			{
				Config: dmsEndpointKinesisConfig(randId),
				Check: resource.ComposeTestCheckFunc(
					checkDmsEndpointExists(resourceName),
					resource.TestCheckResourceAttr(resourceName, "kinesis_settings.#", "1"),
					resource.TestCheckResourceAttr(resourceName, "kinesis_settings.0.message_format", "json"),
					resource.TestCheckResourceAttrPair(resourceName, "kinesis_settings.0.stream_arn", "aws_kinesis_stream.stream1", "arn"),
					resource.TestCheckResourceAttrPair(resourceName, "kinesis_settings.0.include_null_and_empty", "aws_kinesis_stream.stream1", "true"),
				),
			},
			{
				ResourceName:            resourceName,
				ImportState:             true,
				ImportStateVerify:       true,
				ImportStateVerifyIgnore: []string{"password"},
			},
			{
				Config: dmsEndpointKinesisConfigUpdate(randId),
				Check: resource.ComposeTestCheckFunc(
					checkDmsEndpointExists(resourceName),
					resource.TestCheckResourceAttr(resourceName, "kinesis_settings.#", "1"),
					resource.TestCheckResourceAttr(resourceName, "kinesis_settings.0.message_format", "json"),
					resource.TestCheckResourceAttrPair(resourceName, "kinesis_settings.0.stream_arn", "aws_kinesis_stream.stream2", "arn"),
					resource.TestCheckResourceAttrPair(resourceName, "kinesis_settings.0.include_null_and_empty", "aws_kinesis_stream.stream1", "false"),
				),
			},
		},
	})
}

[github-actions]

Welcome @ksagle77 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[vikatskhay]

@ksagle77 thank you for adding this. Would it be possible to add support for IncludeTransactionDetails as well? (Duplicating the request in #20083 (comment).)

[ewbankkit]

Similar #18750.

[ewbankkit]

@ksagle77 Thanks for the contribution 🎉 👏.

[ewbankkit]

LGTM 🚀.

$ make testacc TESTARGS='-run=TestAccDMSEndpoint_' PKG_NAME=internal/service/dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms -v -count 1 -parallel 20 -run=TestAccDMSEndpoint_ -timeout 180m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_s3
=== PAUSE TestAccDMSEndpoint_s3
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_dynamoDB
=== PAUSE TestAccDMSEndpoint_dynamoDB
=== RUN   TestAccDMSEndpoint_elasticSearch
=== PAUSE TestAccDMSEndpoint_elasticSearch
=== RUN   TestAccDMSEndpoint_ElasticSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_ElasticSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_ElasticSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_ElasticSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_ElasticSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_ElasticSearch_fullLoadErrorPercentage
=== RUN   TestAccDMSEndpoint_kafka
=== PAUSE TestAccDMSEndpoint_kafka
=== RUN   TestAccDMSEndpoint_kinesis
=== PAUSE TestAccDMSEndpoint_kinesis
=== RUN   TestAccDMSEndpoint_mongoDB
=== PAUSE TestAccDMSEndpoint_mongoDB
=== RUN   TestAccDMSEndpoint_MongoDB_update
=== PAUSE TestAccDMSEndpoint_MongoDB_update
=== RUN   TestAccDMSEndpoint_docDB
=== PAUSE TestAccDMSEndpoint_docDB
=== RUN   TestAccDMSEndpoint_db2
=== PAUSE TestAccDMSEndpoint_db2
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_kafka
=== CONT  TestAccDMSEndpoint_db2
=== CONT  TestAccDMSEndpoint_docDB
=== CONT  TestAccDMSEndpoint_MongoDB_update
=== CONT  TestAccDMSEndpoint_mongoDB
=== CONT  TestAccDMSEndpoint_kinesis
=== CONT  TestAccDMSEndpoint_elasticSearch
=== CONT  TestAccDMSEndpoint_ElasticSearch_fullLoadErrorPercentage
=== CONT  TestAccDMSEndpoint_ElasticSearch_errorRetryDuration
=== CONT  TestAccDMSEndpoint_ElasticSearch_extraConnectionAttributes
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
=== CONT  TestAccDMSEndpoint_dynamoDB
=== CONT  TestAccDMSEndpoint_s3
--- PASS: TestAccDMSEndpoint_mongoDB (152.48s)
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (173.79s)
--- PASS: TestAccDMSEndpoint_ElasticSearch_errorRetryDuration (173.85s)
--- PASS: TestAccDMSEndpoint_elasticSearch (173.85s)
--- PASS: TestAccDMSEndpoint_ElasticSearch_extraConnectionAttributes (173.86s)
--- PASS: TestAccDMSEndpoint_ElasticSearch_fullLoadErrorPercentage (173.95s)
--- PASS: TestAccDMSEndpoint_kafka (181.68s)
--- PASS: TestAccDMSEndpoint_docDB (182.84s)
--- PASS: TestAccDMSEndpoint_basic (182.90s)
--- PASS: TestAccDMSEndpoint_db2 (183.23s)
--- PASS: TestAccDMSEndpoint_dynamoDB (192.89s)
--- PASS: TestAccDMSEndpoint_s3 (193.44s)
--- PASS: TestAccDMSEndpoint_MongoDB_update (197.49s)
--- PASS: TestAccDMSEndpoint_kinesis (221.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	221.256s

[ewbankkit]

@ksagle77 @kduvekot-wehkamp-nl Thanks for the contribution 🎉 👏.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.