r/aws_route_table_association: Wait for 40 NotFoundChecks

[ryancragun]

We have many automated tests that create route table associations and have witnessed extreme variance in the duration when waiting for the aws_route_table_association resource to be found after it is initially created. Most of the time, the aws_route_table_association resource finishes in about 1 second, while in others it'll retry until we hit the default 20 MaxNotFound checks in the StateChangeConf waiter, which causes the resource to always fail around the 2.5 minute mark when this condition is exhibited. This change increases the max NotFoundChecks for the RouteTableAssociationCreated StateChangeConf waiter to 40, which gets us closer to the max default timeout of 5 minutes. After having built my own copy of the provider plugin with this change we no longer see this issue.

Before:

After:

I didn't include a modified acceptance test because the issue itself is quite sporadic and we cannot control the conditions of the AWS Ec2 API to sufficiently test the change. Looking further into the waiter and finder themselves, it would appear that testing at that level would require building an ec2.EC2 connection mock, which in turn means that we'd really only be testing the StateChangeConf implementation, which has nothing to do with our changes.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

ACCTEST_PARALLELISM=2 make testacc TESTARGS='-run=TestAccAWSRouteTableAssociation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteTableAssociation -timeout 180m
=== RUN   TestAccAWSRouteTableAssociation_Subnet_basic
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_basic
=== RUN   TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_Gateway_basic
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_basic
=== RUN   TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_disappears
=== PAUSE TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Subnet_basic
=== CONT  TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (39.18s)
=== CONT  TestAccAWSRouteTableAssociation_Gateway_basic
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (88.16s)
=== CONT  TestAccAWSRouteTableAssociation_disappears
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (70.08s)
=== CONT  TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
--- PASS: TestAccAWSRouteTableAssociation_disappears (36.22s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (56.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       168.660s

Note that ACCTEST_PARALLELISM is at 2 because of the maximum allowed internet gateways in my ec2 account. With the default of 20 we'd run into that limit.

[github-actions]

Welcome @ryancragun 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTableAssociation_ -timeout 180m
=== RUN   TestAccAWSRouteTableAssociation_Subnet_basic
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_basic
=== RUN   TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_Gateway_basic
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_basic
=== RUN   TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_disappears
=== PAUSE TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Subnet_basic
=== CONT  TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== CONT  TestAccAWSRouteTableAssociation_Gateway_basic
=== CONT  TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
--- PASS: TestAccAWSRouteTableAssociation_disappears (46.16s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (48.98s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (71.13s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (80.13s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (103.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	108.328s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSRouteTableAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRouteTableAssociation_ -timeout 180m
=== RUN   TestAccAWSRouteTableAssociation_Subnet_basic
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_basic
=== RUN   TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_Gateway_basic
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_basic
=== RUN   TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== PAUSE TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== RUN   TestAccAWSRouteTableAssociation_disappears
=== PAUSE TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Subnet_basic
=== CONT  TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable
=== CONT  TestAccAWSRouteTableAssociation_disappears
=== CONT  TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable
=== CONT  TestAccAWSRouteTableAssociation_Gateway_basic
--- PASS: TestAccAWSRouteTableAssociation_disappears (47.91s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_basic (51.82s)
--- PASS: TestAccAWSRouteTableAssociation_Subnet_ChangeRouteTable (73.77s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_basic (84.15s)
--- PASS: TestAccAWSRouteTableAssociation_Gateway_ChangeRouteTable (106.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	112.590s

[ewbankkit]

@ryancragun Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.