Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws_dms_endpoint ressource to support new engines #21174

Merged
merged 5 commits into from
Oct 7, 2021

Conversation

dsarrio
Copy link
Contributor

@dsarrio dsarrio commented Oct 6, 2021

AWS now supports more engines in dms endpoints. List of allowed values have been updated accordingly.

Reference:

Screenshot 2021-10-06 at 12 48 42

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19150

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/databasemigrationservice size/XS Managed by automation to categorize the size of a PR. and removed service/databasemigrationservice labels Oct 6, 2021
@dsarrio dsarrio changed the title [WIP] Update aws_dms_endpoint ressource to support new engines Update aws_dms_endpoint ressource to support new engines Oct 6, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dsarrio 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAwsDmsEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDmsEndpoint_ -timeout 180m
=== RUN   TestAccAwsDmsEndpoint_basic
=== PAUSE TestAccAwsDmsEndpoint_basic
=== RUN   TestAccAwsDmsEndpoint_S3
=== PAUSE TestAccAwsDmsEndpoint_S3
=== RUN   TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
=== PAUSE TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
=== RUN   TestAccAwsDmsEndpoint_DynamoDb
=== PAUSE TestAccAwsDmsEndpoint_DynamoDb
=== RUN   TestAccAwsDmsEndpoint_Elasticsearch
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch
=== RUN   TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes
=== RUN   TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration
=== RUN   TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage
=== PAUSE TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage
=== RUN   TestAccAwsDmsEndpoint_Kafka_Broker
=== PAUSE TestAccAwsDmsEndpoint_Kafka_Broker
=== RUN   TestAccAwsDmsEndpoint_Kafka_Topic
=== PAUSE TestAccAwsDmsEndpoint_Kafka_Topic
=== RUN   TestAccAwsDmsEndpoint_Kinesis
=== PAUSE TestAccAwsDmsEndpoint_Kinesis
=== RUN   TestAccAwsDmsEndpoint_MongoDb
=== PAUSE TestAccAwsDmsEndpoint_MongoDb
=== RUN   TestAccAwsDmsEndpoint_MongoDb_Update
=== PAUSE TestAccAwsDmsEndpoint_MongoDb_Update
=== RUN   TestAccAwsDmsEndpoint_DocDB
=== PAUSE TestAccAwsDmsEndpoint_DocDB
=== RUN   TestAccAwsDmsEndpoint_Db2
=== PAUSE TestAccAwsDmsEndpoint_Db2
=== CONT  TestAccAwsDmsEndpoint_basic
=== CONT  TestAccAwsDmsEndpoint_Kafka_Broker
=== CONT  TestAccAwsDmsEndpoint_MongoDb
=== CONT  TestAccAwsDmsEndpoint_MongoDb_Update
=== CONT  TestAccAwsDmsEndpoint_DocDB
=== CONT  TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes
=== CONT  TestAccAwsDmsEndpoint_Db2
=== CONT  TestAccAwsDmsEndpoint_Kinesis
=== CONT  TestAccAwsDmsEndpoint_Elasticsearch
=== CONT  TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes
=== CONT  TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration
=== CONT  TestAccAwsDmsEndpoint_DynamoDb
=== CONT  TestAccAwsDmsEndpoint_Kafka_Topic
=== CONT  TestAccAwsDmsEndpoint_S3
=== CONT  TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage
--- PASS: TestAccAwsDmsEndpoint_MongoDb (28.89s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_FullLoadErrorPercentage (41.59s)
--- PASS: TestAccAwsDmsEndpoint_S3_ExtraConnectionAttributes (41.69s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch (43.47s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Broker (43.49s)
--- PASS: TestAccAwsDmsEndpoint_Kafka_Topic (43.72s)
--- PASS: TestAccAwsDmsEndpoint_basic (44.18s)
--- PASS: TestAccAwsDmsEndpoint_DocDB (44.35s)
--- PASS: TestAccAwsDmsEndpoint_Db2 (44.39s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ErrorRetryDuration (45.88s)
--- PASS: TestAccAwsDmsEndpoint_MongoDb_Update (48.82s)
--- PASS: TestAccAwsDmsEndpoint_Elasticsearch_ExtraConnectionAttributes (50.84s)
--- PASS: TestAccAwsDmsEndpoint_DynamoDb (61.51s)
--- PASS: TestAccAwsDmsEndpoint_S3 (61.87s)
--- PASS: TestAccAwsDmsEndpoint_Kinesis (103.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	107.140s

@ewbankkit
Copy link
Contributor

@dsarrio Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a2ea7a0 into hashicorp:main Oct 7, 2021
@github-actions github-actions bot added this to the v3.62.0 milestone Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dms_endpoint engine_name not validated correctly
3 participants