Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow run_configurations to be set on Kinesis AnalyticsV2 #21303

Merged

Conversation

bambro
Copy link
Contributor

@bambro bambro commented Oct 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19209 where run_configurations are not preserved on update actions to kinesis analytics V2 applications.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSKinesisAnalyticsV2Application'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsV2Application -timeout 180m
=== RUN   TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_basic
=== PAUSE TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_basic
=== RUN   TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears
=== PAUSE TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears
=== RUN   TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears_Application
=== PAUSE TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears_Application
=== RUN   TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== RUN   TestAccAWSKinesisAnalyticsV2Application_basicSQLApplication
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_basicSQLApplication
=== RUN   TestAccAWSKinesisAnalyticsV2Application_disappears
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_disappears
=== RUN   TestAccAWSKinesisAnalyticsV2Application_Tags
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_Tags
=== RUN   TestAccAWSKinesisAnalyticsV2Application_ApplicationCodeConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_ApplicationCodeConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Add
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Add
=== RUN   TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Delete
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Delete
=== RUN   TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_EnvironmentProperties_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_EnvironmentProperties_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_EnvironmentProperties_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_EnvironmentProperties_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_RestoreFromSnapshot
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_RestoreFromSnapshot
=== RUN   TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnCreate
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnCreate
=== RUN   TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnUpdate
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnUpdate
=== RUN   TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_UpdateRunning
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_UpdateRunning
=== RUN   TestAccAWSKinesisAnalyticsV2Application_ServiceExecutionRole_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_ServiceExecutionRole_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Add
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Add
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Multiple_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Multiple_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Output_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Output_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Add
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Add
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Delete
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Delete
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnCreate
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnCreate
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnUpdate
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnUpdate
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_UpdateRunning
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_UpdateRunning
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Add
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Add
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Delete
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Delete
=== RUN   TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_Update
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_Update
=== RUN   TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Update (0.00s)
=== RUN   TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Delete
--- PASS: TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Delete (0.00s)
=== CONT  TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_basic
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Add
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Multiple_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Delete
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Add
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Delete
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Add
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_UpdateRunning
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnUpdate
=== CONT  TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnCreate
=== CONT  TestAccAWSKinesisAnalyticsV2Application_ServiceExecutionRole_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_UpdateRunning
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnCreate
=== CONT  TestAccAWSKinesisAnalyticsV2Application_disappears
=== CONT  TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_Update
=== CONT  TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnUpdate
--- PASS: TestAccAWSKinesisAnalyticsV2Application_disappears (74.49s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Delete
--- PASS: TestAccAWSKinesisAnalyticsV2Application_ServiceExecutionRole_Update (110.97s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Add
--- PASS: TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Delete (105.01s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_ApplicationCodeConfiguration_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Add (104.59s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_Tags
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Update (225.24s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnCreate (225.44s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_RestoreFromSnapshot
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Add (233.66s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
--- PASS: TestAccAWSKinesisAnalyticsV2Application_ApplicationCodeConfiguration_Update (93.25s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_basicSQLApplication
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Input_Update (313.21s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Output_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Update (315.73s)
=== CONT  TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears_Application
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Add (316.40s)
=== CONT  TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_VPCConfiguration_Delete (316.88s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Add
--- PASS: TestAccAWSKinesisAnalyticsV2Application_CloudWatchLoggingOptions_Update (93.94s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Delete
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Multiple_Update (322.21s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_basicSQLApplication (58.34s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_EnvironmentProperties_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_Tags (128.04s)
=== CONT  TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_EnvironmentProperties_Update
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Add (364.91s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication (133.85s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Delete (380.40s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_InputProcessingConfiguration_Update (382.50s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_UpdateRunning (405.06s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_StartApplication_OnUpdate (436.27s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnCreate (480.01s)
--- PASS: TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_basic (511.74s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_Update (225.46s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Add (234.97s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_StartApplication_OnUpdate (552.69s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_EnvironmentProperties_Update (225.35s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_ReferenceDataSource_Delete (272.12s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_EnvironmentProperties_Update (286.06s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_SQLApplicationConfiguration_Output_Update (327.57s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_Update (653.08s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_UpdateRunning (686.31s)
--- PASS: TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears (382.87s)
--- PASS: TestAccAWSKinesisAnalyticsV2ApplicationSnapshot_disappears_Application (395.68s)
--- PASS: TestAccAWSKinesisAnalyticsV2Application_FlinkApplicationConfiguration_RestoreFromSnapshot (868.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1095.719s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 14, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @bambro 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 14, 2021
@bambro bambro force-pushed the f-kinesis-application-run-configurations branch from 17ab44d to 133068d Compare October 14, 2021 22:40
@github-actions github-actions bot removed the service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. label Oct 14, 2021
@YakDriver
Copy link
Member

YakDriver commented Oct 15, 2021

@bambro As far as I know, you have the honor of being the first person to update their PR for the new structure. I'm going to cite this as an example of what to do. Excellent work! See #20000 for additional guidance.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looking pretty good. There are still some post #20000 changes.

internal/service/kinesisanalyticsv2/application_test.go Outdated Show resolved Hide resolved
internal/service/kinesisanalyticsv2/application_test.go Outdated Show resolved Hide resolved
internal/service/kinesisanalyticsv2/application_test.go Outdated Show resolved Hide resolved
internal/service/kinesisanalyticsv2/application.go Outdated Show resolved Hide resolved
internal/service/kinesisanalyticsv2/application_test.go Outdated Show resolved Hide resolved
}

func TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Update(t *testing.T) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I forgot to remove this. main flow of the change should be tested in TestAccKinesisAnalyticsV2Application_RunConfiguration_Update

}

func TestAccAWSKinesisAnalyticsV2Application_RunConfiguration_FlinkRunConfiguration_Delete(t *testing.T) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have also been removed as main test TestAccKinesisAnalyticsV2Application_RunConfiguration_Update should capture the main flow of the change

internal/service/kinesisanalyticsv2/application_test.go Outdated Show resolved Hide resolved
internal/service/kinesisanalyticsv2/application_test.go Outdated Show resolved Hide resolved
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
@github-actions github-actions bot added the service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. label Oct 18, 2021
@bambro
Copy link
Contributor Author

bambro commented Oct 18, 2021

Results after request changes:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesisanalyticsv2 -v -count 1 -parallel 20 -run=TestAccKinesisAnalyticsV2Application -timeout 180m
=== RUN   TestAccKinesisAnalyticsV2ApplicationSnapshot_basic
=== PAUSE TestAccKinesisAnalyticsV2ApplicationSnapshot_basic
=== RUN   TestAccKinesisAnalyticsV2ApplicationSnapshot_disappears
=== PAUSE TestAccKinesisAnalyticsV2ApplicationSnapshot_disappears
=== RUN   TestAccKinesisAnalyticsV2ApplicationSnapshot_Disappears_application
=== PAUSE TestAccKinesisAnalyticsV2ApplicationSnapshot_Disappears_application
=== RUN   TestAccKinesisAnalyticsV2Application_basicFlinkApplication
=== PAUSE TestAccKinesisAnalyticsV2Application_basicFlinkApplication
=== RUN   TestAccKinesisAnalyticsV2Application_basicSQLApplication
=== PAUSE TestAccKinesisAnalyticsV2Application_basicSQLApplication
=== RUN   TestAccKinesisAnalyticsV2Application_disappears
=== PAUSE TestAccKinesisAnalyticsV2Application_disappears
=== RUN   TestAccKinesisAnalyticsV2Application_tags
=== PAUSE TestAccKinesisAnalyticsV2Application_tags
=== RUN   TestAccKinesisAnalyticsV2Application_ApplicationCode_update
=== PAUSE TestAccKinesisAnalyticsV2Application_ApplicationCode_update
=== RUN   TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_add
=== PAUSE TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_add
=== RUN   TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_delete
=== PAUSE TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_delete
=== RUN   TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_update
=== PAUSE TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_update
=== RUN   TestAccKinesisAnalyticsV2Application_EnvironmentProperties_update
=== PAUSE TestAccKinesisAnalyticsV2Application_EnvironmentProperties_update
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplication_update
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplication_update
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplicationEnvironmentProperties_update
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplicationEnvironmentProperties_update
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplication_restoreFromSnapshot
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplication_restoreFromSnapshot
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onCreate
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onCreate
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onUpdate
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onUpdate
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRunning
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRunning
=== RUN   TestAccKinesisAnalyticsV2Application_ServiceExecutionRole_update
=== PAUSE TestAccKinesisAnalyticsV2Application_ServiceExecutionRole_update
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationInput_add
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationInput_add
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationInput_update
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationInput_update
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_add
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_add
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_delete
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_delete
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_update
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_update
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationMultiple_update
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationMultiple_update
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationOutput_update
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationOutput_update
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_add
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_add
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_delete
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_delete
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_update
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_update
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onCreate
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onCreate
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onUpdate
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onUpdate
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplication_updateRunning
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplication_updateRunning
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_add
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_add
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_delete
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_delete
=== RUN   TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_update
=== PAUSE TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_update
=== RUN   TestAccKinesisAnalyticsV2Application_RunConfiguration_Update
=== PAUSE TestAccKinesisAnalyticsV2Application_RunConfiguration_Update
=== CONT  TestAccKinesisAnalyticsV2ApplicationSnapshot_basic
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_add
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_delete
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_delete
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_add
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplication_updateRunning
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onUpdate
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplicationEnvironmentProperties_update
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onCreate
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_update
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_update
=== CONT  TestAccKinesisAnalyticsV2Application_RunConfiguration_Update
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_delete
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationInput_update
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationOutput_update
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationMultiple_update
=== CONT  TestAccKinesisAnalyticsV2Application_ApplicationCode_update
=== CONT  TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_delete
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_update
=== CONT  TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_add
--- PASS: TestAccKinesisAnalyticsV2Application_ApplicationCode_update (165.94s)
=== CONT  TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_update
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_add (168.27s)
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplication_update
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_delete (168.75s)
=== CONT  TestAccKinesisAnalyticsV2Application_EnvironmentProperties_update
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onCreate (196.67s)
=== CONT  TestAccKinesisAnalyticsV2Application_basicSQLApplication
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_delete (253.99s)
=== CONT  TestAccKinesisAnalyticsV2Application_disappears
=== CONT  TestAccKinesisAnalyticsV2ApplicationSnapshot_Disappears_application
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_add (259.87s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_update (260.77s)
=== CONT  TestAccKinesisAnalyticsV2ApplicationSnapshot_disappears
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_delete (261.56s)
=== CONT  TestAccKinesisAnalyticsV2Application_tags
--- PASS: TestAccKinesisAnalyticsV2Application_basicSQLApplication (67.86s)
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRunning
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_update (264.76s)
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationInput_add
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_update (267.12s)
=== CONT  TestAccKinesisAnalyticsV2Application_ServiceExecutionRole_update
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_update (106.89s)
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onCreate
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_delete (277.79s)
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onUpdate
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationEnvironmentProperties_update (295.18s)
=== CONT  TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_add
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationMultiple_update (321.64s)
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplication_restoreFromSnapshot
--- PASS: TestAccKinesisAnalyticsV2Application_disappears (69.11s)
=== CONT  TestAccKinesisAnalyticsV2Application_basicFlinkApplication
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInput_update (367.92s)
--- PASS: TestAccKinesisAnalyticsV2Application_ServiceExecutionRole_update (127.16s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_update (237.55s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_add (409.38s)
--- PASS: TestAccKinesisAnalyticsV2Application_tags (183.35s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationOutput_update (446.84s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplication_updateRunning (449.52s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onUpdate (453.46s)
--- PASS: TestAccKinesisAnalyticsV2Application_EnvironmentProperties_update (299.13s)
--- PASS: TestAccKinesisAnalyticsV2ApplicationSnapshot_basic (471.22s)
--- PASS: TestAccKinesisAnalyticsV2Application_basicFlinkApplication (164.13s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_add (227.70s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInput_add (269.96s)
--- PASS: TestAccKinesisAnalyticsV2Application_RunConfiguration_Update (589.93s)
--- PASS: TestAccKinesisAnalyticsV2ApplicationSnapshot_disappears (341.17s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onCreate (377.81s)
--- PASS: TestAccKinesisAnalyticsV2ApplicationSnapshot_Disappears_application (464.70s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onUpdate (495.40s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRunning (622.89s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_restoreFromSnapshot (707.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2	1030.683s

@bambro bambro requested a review from YakDriver October 18, 2021 07:19
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Output from acceptance test (us-west-2):

--- PASS: TestAccKinesisAnalyticsV2Application_ApplicationCode_update (39.72s)
--- PASS: TestAccKinesisAnalyticsV2Application_basicFlinkApplication (70.74s)
--- PASS: TestAccKinesisAnalyticsV2Application_basicSQLApplication (28.80s)
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_add (70.23s)
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_delete (44.02s)
--- PASS: TestAccKinesisAnalyticsV2Application_CloudWatchLoggingOptions_update (42.33s)
--- PASS: TestAccKinesisAnalyticsV2Application_disappears (27.73s)
--- PASS: TestAccKinesisAnalyticsV2Application_EnvironmentProperties_update (339.14s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_restoreFromSnapshot (1054.96s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_update (463.58s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRunning (805.08s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationEnvironmentProperties_update (465.91s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onCreate (682.44s)
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplicationStartApplication_onUpdate (700.10s)
--- PASS: TestAccKinesisAnalyticsV2Application_RunConfiguration_Update (748.68s)
--- PASS: TestAccKinesisAnalyticsV2Application_ServiceExecutionRole_update (45.86s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplication_updateRunning (322.74s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInput_add (160.81s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInput_update (229.19s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_add (150.29s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_delete (151.66s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationInputProcessing_update (159.94s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationMultiple_update (132.56s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationOutput_update (250.04s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_add (173.95s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_delete (132.89s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationReferenceDataSource_update (127.03s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onCreate (157.91s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationStartApplication_onUpdate (253.35s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_add (459.57s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_delete (450.07s)
--- PASS: TestAccKinesisAnalyticsV2Application_SQLApplicationVPC_update (459.69s)
--- PASS: TestAccKinesisAnalyticsV2Application_tags (53.51s)

@YakDriver YakDriver added this to the v3.64.0 milestone Oct 18, 2021
@YakDriver YakDriver merged commit 3c5c546 into hashicorp:main Oct 18, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kinesis AnalyticsV2 Allow Non Restored State Parameter Problem
3 participants