[Bug]: The efs_file_system data source resource does not follow pagination

[avaines]

Terraform Core Version

latest

AWS Provider Version

latest

Affected Resource(s)

data.aws_efs_file_system

Expected Behavior

When an AWS account has more than 101 EFS resources defined you should be able to source the 101st resource based on its tags.

Actual Behavior

The AWS EFS Describe File Systems endpoint does not support filtering and this provider does so post-response. The endpoint is returning a paginated response which is not being followed.

Relevant Error/Panic Output Snippet

Error: Search returned 0 results, please revise so only one is returned
│
│   with data.aws_efs_file_system.myfiles,
│   on data_efs_file_system_myfiles.tf line 1, in data "aws_efs_file_system" "myfiles":
│    1: data "aws_efs_file_system" "myfiles" {

Terraform Configuration Files

data "aws_efs_file_system" "replica_myfiles" {
   tags = {
     Description       = "myfiles"
     Environment     = var.environment
     Application       = var.application_name
     ReplicState       = "next"
   }
}

Steps to Reproduce

Have 101 or more EFS resources in the AWS account and reference the oldest resource based on its tags.

Debug Output

No response

Panic Output

No response

Important Factoids

I am fairly certain this is a result of this resource not following pagination provided in the AWS endpoint response

References

This seems to have been similar issues for other services, for example
#4531

Would you like to implement a fix?

No

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v5.16.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.