Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source]: aws_appmesh_virtual_router #26908

Closed
ChrisMKinsella opened this issue Sep 21, 2022 · 5 comments · Fixed by #29064
Closed

[New Data Source]: aws_appmesh_virtual_router #26908

ChrisMKinsella opened this issue Sep 21, 2022 · 5 comments · Fixed by #29064
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/appmesh Issues and PRs that pertain to the appmesh service.

Comments

@ChrisMKinsella
Copy link

ChrisMKinsella commented Sep 21, 2022

Description

Could we request a new aws_appmesh_virtual_router data source so we can lookup the resources by attitbutes or tags.

Requested Resource(s) and/or Data Source(s)

aws_appmesh_virtual_router

Potential Terraform Configuration

data "aws_appmesh_virtual_router" "sample_filtered_on_name" {
    name = "simpleapp"
}

data "aws_appmesh_virtual_router" "sample_filtered_on_tag_name" {
   tags = {
    myTag = "simpleapp_virtual_router"
   }
}

References

No response

Would you like to implement a fix?

No

@ChrisMKinsella ChrisMKinsella added the needs-triage Waiting for first response or review from a maintainer. label Sep 21, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appmesh Issues and PRs that pertain to the appmesh service. label Sep 21, 2022
@justinretzolk justinretzolk added new-data-source Introduces a new data source. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2022
@vijal-patel
Copy link

Could I pick this one up?

@alowder94
Copy link
Contributor

Planning to poke at this one

@ewbankkit
Copy link
Contributor

Relates #17590.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. new-data-source Introduces a new data source. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
5 participants