Add App Mesh Virtual Gateway Target Ports #29064

benmurden · 2023-01-24T08:08:30Z

Description

Virtual Gateway Routes must define a target port when the targeted virtual service has multiple listeners. This PR adds port to the target block.

Additionally, I notice the docs incorrectly reference a port in the rewrite block. This PR will also fix the documentation.

Relations

Closes #29063.
Closes #29283.
Closes #26908.
Closes #26910.
Closes #17590.
Closes #21345.
Closes #21389.
Closes #28614.
Closes #24415.
Closes #30026.
Closes #27683.

References

https://docs.aws.amazon.com/app-mesh/latest/userguide/gateway-routes.html
https://github.com/aws/aws-app-mesh-examples/blob/main/walkthroughs/howto-multiple-listeners/mesh/color-gateway-route.json
https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_CreateGatewayRoute.html

Output from Acceptance Testing

$ make testacc TESTS="TestAccAppMesh_serial" PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run='TestAccAppMesh_serial'  -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/basic
=== RUN   TestAccAppMesh_serial/Mesh/egressFilter
=== RUN   TestAccAppMesh_serial/Mesh/tags
=== RUN   TestAccAppMesh_serial/Route
=== RUN   TestAccAppMesh_serial/Route/disappears
=== RUN   TestAccAppMesh_serial/Route/grpcRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAppMesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/http2RouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/tcpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/grpcRouteEmptyMatch
=== RUN   TestAccAppMesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/http2Route
=== RUN   TestAccAppMesh_serial/Route/httpHeader
=== RUN   TestAccAppMesh_serial/Route/routePriority
=== RUN   TestAccAppMesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAppMesh_serial/Route/httpRoute
=== RUN   TestAccAppMesh_serial/Route/httpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/tcpRoute
=== RUN   TestAccAppMesh_serial/Route/tags
=== RUN   TestAccAppMesh_serial/VirtualGateway
=== RUN   TestAccAppMesh_serial/VirtualGateway/disappears
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualGateway/tags
=== RUN   TestAccAppMesh_serial/VirtualGateway/basic
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/logging
=== RUN   TestAccAppMesh_serial/VirtualNode
=== RUN   TestAccAppMesh_serial/VirtualNode/tags
=== RUN   TestAccAppMesh_serial/VirtualNode/disappears
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualNode/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/basic
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualNode/logging
=== RUN   TestAccAppMesh_serial/VirtualRouter
=== RUN   TestAccAppMesh_serial/VirtualRouter/basic
=== RUN   TestAccAppMesh_serial/VirtualRouter/disappears
=== RUN   TestAccAppMesh_serial/VirtualRouter/multiListener
=== RUN   TestAccAppMesh_serial/VirtualRouter/tags
=== RUN   TestAccAppMesh_serial/VirtualService
=== RUN   TestAccAppMesh_serial/VirtualService/tags
=== RUN   TestAccAppMesh_serial/VirtualService/disappears
=== RUN   TestAccAppMesh_serial/VirtualService/virtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAppMesh_serial/GatewayRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/disappears
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2Route
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/basic
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/tags
--- PASS: TestAccAppMesh_serial (2166.64s)
    --- PASS: TestAccAppMesh_serial/Mesh (88.55s)
        --- PASS: TestAccAppMesh_serial/Mesh/basic (18.37s)
        --- PASS: TestAccAppMesh_serial/Mesh/egressFilter (35.25s)
        --- PASS: TestAccAppMesh_serial/Mesh/tags (34.93s)
    --- PASS: TestAccAppMesh_serial/Route (590.41s)
        --- PASS: TestAccAppMesh_serial/Route/disappears (16.27s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRoute (46.85s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (51.68s)
        --- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (42.01s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (32.23s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (27.18s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (27.01s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (38.53s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (18.00s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (27.78s)
        --- PASS: TestAccAppMesh_serial/Route/http2Route (27.11s)
        --- PASS: TestAccAppMesh_serial/Route/httpHeader (28.63s)
        --- PASS: TestAccAppMesh_serial/Route/routePriority (27.02s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (27.88s)
        --- PASS: TestAccAppMesh_serial/Route/httpRoute (38.59s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (38.42s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRoute (37.75s)
        --- PASS: TestAccAppMesh_serial/Route/tags (37.47s)
    --- PASS: TestAccAppMesh_serial/VirtualGateway (314.21s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (14.54s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (26.65s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (27.05s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (26.11s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (71.95s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/tags (36.09s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/basic (17.06s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (17.77s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (25.90s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (25.62s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/logging (25.46s)
    --- PASS: TestAccAppMesh_serial/VirtualNode (557.48s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/tags (35.47s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/disappears (14.41s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile (25.64s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection (26.61s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTimeout (26.25s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTls (70.55s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/multiListenerValidation (26.03s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/basic (16.34s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaults (26.80s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery (112.54s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerHealthChecks (26.19s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerValidation (25.39s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm (56.53s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate (16.94s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (26.29s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/logging (25.52s)
    --- PASS: TestAccAppMesh_serial/VirtualRouter (110.79s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/basic (26.97s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/disappears (14.53s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/multiListener (31.70s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/tags (37.59s)
    --- PASS: TestAccAppMesh_serial/VirtualService (109.27s)
        --- PASS: TestAccAppMesh_serial/VirtualService/tags (40.08s)
        --- PASS: TestAccAppMesh_serial/VirtualService/disappears (16.55s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (27.29s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (25.34s)
    --- PASS: TestAccAppMesh_serial/GatewayRoute (395.93s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (15.60s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (47.58s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (27.95s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (46.72s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (46.58s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (17.33s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (27.56s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (27.96s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (27.07s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (46.22s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (28.93s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (36.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    2167.102s

github-actions · 2023-01-24T08:08:44Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Fmowers

These changes need to also be applied to the regular route resource. Also the ability to match on port needs to be implemented rather than removed from the documentation. This again is the same for regular route resource.

website/docs/r/appmesh_gateway_route.html.markdown

benmurden · 2023-03-02T00:17:39Z

The above concerns were addressed last month. Is there anything else I can do to help get this merged?

…ete.

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^GatewayRoute$$' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^GatewayRoute$ -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/GatewayRoute === RUN TestAccAppMesh_serial/GatewayRoute/basic === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/tags === RUN TestAccAppMesh_serial/GatewayRoute/dataSourceBasic === RUN TestAccAppMesh_serial/GatewayRoute/disappears === RUN TestAccAppMesh_serial/GatewayRoute/grpcRoute === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRoute === RUN TestAccAppMesh_serial/GatewayRoute/http2Route === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort --- PASS: TestAccAppMesh_serial (425.11s) --- PASS: TestAccAppMesh_serial/GatewayRoute (425.11s) --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (17.38s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (29.21s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (29.89s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (49.58s) --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (39.81s) --- PASS: TestAccAppMesh_serial/GatewayRoute/dataSourceBasic (15.33s) --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (13.64s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (28.18s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (27.62s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (49.60s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (50.79s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (29.98s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (50.86s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 440.219s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^GatewayRoute$$' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^GatewayRoute$ -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/GatewayRoute === RUN TestAccAppMesh_serial/GatewayRoute/disappears === RUN TestAccAppMesh_serial/GatewayRoute/grpcRoute === RUN TestAccAppMesh_serial/GatewayRoute/http2Route === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/tags === RUN TestAccAppMesh_serial/GatewayRoute/basic === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRoute === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/dataSourceBasic --- PASS: TestAccAppMesh_serial (446.31s) --- PASS: TestAccAppMesh_serial/GatewayRoute (446.30s) --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (15.53s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (28.03s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (51.30s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (50.73s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (34.87s) --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (39.06s) --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (16.65s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (35.25s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (27.60s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (51.72s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (29.25s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (50.87s) --- PASS: TestAccAppMesh_serial/GatewayRoute/dataSourceBasic (15.44s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 452.662s

…ence' and 'spec.service_discovery.dns.response_type'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualNode$$/listenerConnectionPool' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^VirtualNode$/listenerConnectionPool -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/VirtualNode === RUN TestAccAppMesh_serial/VirtualNode/listenerConnectionPool --- PASS: TestAccAppMesh_serial (28.52s) --- PASS: TestAccAppMesh_serial/VirtualNode (28.52s) --- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (28.52s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 34.002s

…'spec.http2_route.match.query_parameter'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^Route$$/httpRouteWithQueryParameterMatch' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^Route$/httpRouteWithQueryParameterMatch -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/Route === RUN TestAccAppMesh_serial/Route/httpRouteWithQueryParameterMatch --- PASS: TestAccAppMesh_serial (17.59s) --- PASS: TestAccAppMesh_serial/Route (17.59s) --- PASS: TestAccAppMesh_serial/Route/httpRouteWithQueryParameterMatch (17.59s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 22.860s

…_route.match.path'. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^Route$$/http2RouteWithPathMatch' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^Route$/http2RouteWithPathMatch -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/Route === RUN TestAccAppMesh_serial/Route/http2RouteWithPathMatch --- PASS: TestAccAppMesh_serial (17.61s) --- PASS: TestAccAppMesh_serial/Route (17.61s) --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPathMatch (17.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 23.855s

…route' schemde definitions. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^GatewayRoute$$' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^GatewayRoute$ -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/GatewayRoute === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/http2Route === RUN TestAccAppMesh_serial/GatewayRoute/basic === RUN TestAccAppMesh_serial/GatewayRoute/grpcRoute === RUN TestAccAppMesh_serial/GatewayRoute/httpRoute === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/tags === RUN TestAccAppMesh_serial/GatewayRoute/dataSourceBasic === RUN TestAccAppMesh_serial/GatewayRoute/disappears === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort --- PASS: TestAccAppMesh_serial (421.97s) --- PASS: TestAccAppMesh_serial/GatewayRoute (421.97s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (28.22s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (28.26s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (48.69s) --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (16.20s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (29.48s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (49.35s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (49.31s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (28.67s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (48.85s) --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (37.70s) --- PASS: TestAccAppMesh_serial/GatewayRoute/dataSourceBasic (14.74s) --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (13.72s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (28.79s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 427.109s

…ch' and 'spec.http2_route.match' configuration blocks. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^GatewayRoute$$' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^GatewayRoute$ -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/GatewayRoute === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRoute === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/basic === RUN TestAccAppMesh_serial/GatewayRoute/disappears === RUN TestAccAppMesh_serial/GatewayRoute/grpcRoute === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort === RUN TestAccAppMesh_serial/GatewayRoute/http2Route === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort === RUN TestAccAppMesh_serial/GatewayRoute/tags === RUN TestAccAppMesh_serial/GatewayRoute/dataSourceBasic --- PASS: TestAccAppMesh_serial (380.84s) --- PASS: TestAccAppMesh_serial/GatewayRoute (380.84s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (31.09s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (27.97s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (48.76s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (48.66s) --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (16.19s) --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (13.47s) --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (26.99s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (28.28s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (49.30s) --- FAIL: TestAccAppMesh_serial/GatewayRoute/http2Route (8.56s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (28.82s) --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (37.95s) --- PASS: TestAccAppMesh_serial/GatewayRoute/dataSourceBasic (14.80s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 386.291s

…' and 'spec.http2_route.match' configuration blocks. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^GatewayRoute$$/httpRouteWithPath' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^GatewayRoute$/httpRouteWithPath -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/GatewayRoute === RUN TestAccAppMesh_serial/GatewayRoute/httpRouteWithPath --- PASS: TestAccAppMesh_serial (17.27s) --- PASS: TestAccAppMesh_serial/GatewayRoute (17.27s) --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPath (17.27s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 22.386s

…route.match' and 'spec.http2_route.match' configuration blocks. Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^GatewayRoute$$/http2RouteWithQueryParameter' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^GatewayRoute$/http2RouteWithQueryParameter -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/GatewayRoute === RUN TestAccAppMesh_serial/GatewayRoute/http2RouteWithQueryParameter --- PASS: TestAccAppMesh_serial (17.44s) --- PASS: TestAccAppMesh_serial/GatewayRoute (17.44s) --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithQueryParameter (17.44s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 22.610s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppMesh_serial' PKG=appmesh 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/GatewayRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/dataSourceBasic
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRouteWithPath
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRoute
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2Route
=== RUN   TestAccAppMesh_serial/GatewayRoute/basic
=== RUN   TestAccAppMesh_serial/GatewayRoute/disappears
=== RUN   TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort
=== RUN   TestAccAppMesh_serial/GatewayRoute/http2RouteWithQueryParameter
=== RUN   TestAccAppMesh_serial/GatewayRoute/tags
=== RUN   TestAccAppMesh_serial/Mesh
=== RUN   TestAccAppMesh_serial/Mesh/disappears
=== RUN   TestAccAppMesh_serial/Mesh/egressFilter
=== RUN   TestAccAppMesh_serial/Mesh/tags
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceBasic
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceMeshOwner
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet
=== RUN   TestAccAppMesh_serial/Mesh/dataSourceShared
    acctest.go:771: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccAppMesh_serial/Mesh/basic
=== RUN   TestAccAppMesh_serial/Route
=== RUN   TestAccAppMesh_serial/Route/routePriority
=== RUN   TestAccAppMesh_serial/Route/tcpRoute
=== RUN   TestAccAppMesh_serial/Route/dataSourceTCPRoute
=== RUN   TestAccAppMesh_serial/Route/disappears
=== RUN   TestAccAppMesh_serial/Route/httpRoute
=== RUN   TestAccAppMesh_serial/Route/httpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/httpRouteWithQueryParameterMatch
=== RUN   TestAccAppMesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAppMesh_serial/Route/tcpRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/grpcRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAppMesh_serial/Route/http2Route
=== RUN   TestAccAppMesh_serial/Route/http2RouteWithPathMatch
=== RUN   TestAccAppMesh_serial/Route/httpHeader
=== RUN   TestAccAppMesh_serial/Route/http2RouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/dataSourceHTTPRoute
=== RUN   TestAccAppMesh_serial/Route/dataSourceGRPCRoute
=== RUN   TestAccAppMesh_serial/Route/grpcRouteWithPortMatch
=== RUN   TestAccAppMesh_serial/Route/grpcRouteEmptyMatch
=== RUN   TestAccAppMesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAppMesh_serial/Route/tags
=== RUN   TestAccAppMesh_serial/Route/dataSourceHTTP2Route
=== RUN   TestAccAppMesh_serial/VirtualGateway
=== RUN   TestAccAppMesh_serial/VirtualGateway/disappears
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/tags
=== RUN   TestAccAppMesh_serial/VirtualGateway/basic
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualGateway/logging
=== RUN   TestAccAppMesh_serial/VirtualGateway/dataSourceBasic
=== RUN   TestAccAppMesh_serial/VirtualNode
=== RUN   TestAccAppMesh_serial/VirtualNode/basic
=== RUN   TestAccAppMesh_serial/VirtualNode/dataSourceBasic
=== RUN   TestAccAppMesh_serial/VirtualNode/disappears
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/multiListenerValidation
=== RUN   TestAccAppMesh_serial/VirtualNode/logging
=== RUN   TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualNode/tags
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAppMesh_serial/VirtualRouter
=== RUN   TestAccAppMesh_serial/VirtualRouter/multiListener
=== RUN   TestAccAppMesh_serial/VirtualRouter/tags
=== RUN   TestAccAppMesh_serial/VirtualRouter/dataSourceBasic
=== RUN   TestAccAppMesh_serial/VirtualRouter/basic
=== RUN   TestAccAppMesh_serial/VirtualRouter/disappears
=== RUN   TestAccAppMesh_serial/VirtualService
=== RUN   TestAccAppMesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAppMesh_serial/VirtualService/tags
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode
=== RUN   TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter
=== RUN   TestAccAppMesh_serial/VirtualService/disappears
=== RUN   TestAccAppMesh_serial/VirtualService/virtualNode
--- PASS: TestAccAppMesh_serial (2480.13s)
    --- PASS: TestAccAppMesh_serial/GatewayRoute (471.34s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteTargetPort (30.92s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/dataSourceBasic (15.51s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (28.27s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (28.45s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPath (16.93s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (51.16s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (51.27s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (51.42s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/basic (17.02s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (14.24s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteTargetPort (29.70s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteTargetPort (29.26s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (50.60s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithQueryParameter (16.82s)
        --- PASS: TestAccAppMesh_serial/GatewayRoute/tags (39.79s)
    --- PASS: TestAccAppMesh_serial/Mesh (135.41s)
        --- PASS: TestAccAppMesh_serial/Mesh/disappears (10.92s)
        --- PASS: TestAccAppMesh_serial/Mesh/egressFilter (31.74s)
        --- PASS: TestAccAppMesh_serial/Mesh/tags (36.06s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceBasic (13.66s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceMeshOwner (14.13s)
        --- PASS: TestAccAppMesh_serial/Mesh/dataSourceSpecAndTagsSet (13.71s)
        --- SKIP: TestAccAppMesh_serial/Mesh/dataSourceShared (0.00s)
        --- PASS: TestAccAppMesh_serial/Mesh/basic (15.18s)
    --- PASS: TestAccAppMesh_serial/Route (693.26s)
        --- PASS: TestAccAppMesh_serial/Route/routePriority (28.61s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRoute (40.00s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceTCPRoute (15.56s)
        --- PASS: TestAccAppMesh_serial/Route/disappears (14.45s)
        --- PASS: TestAccAppMesh_serial/Route/httpRoute (40.03s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (42.35s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteWithQueryParameterMatch (16.94s)
        --- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (28.26s)
        --- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (40.61s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (39.91s)
        --- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (28.44s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRoute (51.00s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (27.49s)
        --- PASS: TestAccAppMesh_serial/Route/http2Route (28.15s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPathMatch (16.49s)
        --- PASS: TestAccAppMesh_serial/Route/httpHeader (27.50s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (27.43s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceHTTPRoute (15.07s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceGRPCRoute (15.18s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (50.88s)
        --- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (16.59s)
        --- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (28.00s)
        --- PASS: TestAccAppMesh_serial/Route/tags (39.07s)
        --- PASS: TestAccAppMesh_serial/Route/dataSourceHTTP2Route (15.26s)
    --- PASS: TestAccAppMesh_serial/VirtualGateway (337.34s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (12.95s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (15.54s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (26.26s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (25.96s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (26.28s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/tags (36.98s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/basic (15.54s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (26.05s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (25.96s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (74.91s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/logging (36.66s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/dataSourceBasic (14.25s)
    --- PASS: TestAccAppMesh_serial/VirtualNode (592.70s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/basic (15.61s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/dataSourceBasic (14.24s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/disappears (12.85s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm (60.13s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery (114.61s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerValidation (26.73s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/multiListenerValidation (26.83s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/logging (37.49s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile (26.72s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (26.63s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection (26.62s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTls (73.77s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/tags (36.48s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaults (26.10s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate (15.62s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerHealthChecks (26.14s)
        --- PASS: TestAccAppMesh_serial/VirtualNode/listenerTimeout (26.12s)
    --- PASS: TestAccAppMesh_serial/VirtualRouter (115.34s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/multiListener (26.09s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/tags (36.41s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/dataSourceBasic (14.16s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/basic (25.93s)
        --- PASS: TestAccAppMesh_serial/VirtualRouter/disappears (12.74s)
    --- PASS: TestAccAppMesh_serial/VirtualService (134.74s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (24.72s)
        --- PASS: TestAccAppMesh_serial/VirtualService/tags (38.47s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualNode (14.92s)
        --- PASS: TestAccAppMesh_serial/VirtualService/dataSourceVirtualRouter (15.24s)
        --- PASS: TestAccAppMesh_serial/VirtualService/disappears (13.79s)
        --- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (27.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	2485.631s

ewbankkit · 2023-03-25T22:32:59Z

@benmurden @alowder94 Thanks for the contribution 🎉 👏.

github-actions · 2023-03-30T23:26:07Z

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-05-01T02:11:28Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

benmurden added 2 commits January 24, 2023 16:52

Tests for gateway route target port

45ae3ac

Implement Gateway Route taget port

eacf2e3

benmurden added 3 commits January 24, 2023 17:11

Fix test HCL indentations

c4bc856

Add changelog text

43916a5

Update documentation for target port

c27f7f3

github-actions bot added documentation Introduces or discusses updates to documentation. and removed documentation Introduces or discusses updates to documentation. labels Jan 24, 2023

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 24, 2023

benmurden mentioned this pull request Jan 26, 2023

aws_appmesh_virtual_node should support multiple listeners #26380

Closed

Fmowers suggested changes Feb 1, 2023

View reviewed changes

website/docs/r/appmesh_gateway_route.html.markdown Show resolved Hide resolved

benmurden requested a review from Fmowers February 2, 2023 23:00

alowder94 added 3 commits February 6, 2023 09:58

Creating Appmesh Virtual Router Data Source

3f8be7d

Adding Changelog

cf6ae24

Updates to pass linting and fmt testing

3a181ad

bendu approved these changes Feb 14, 2023

View reviewed changes

ewbankkit added 8 commits March 24, 2023 11:33

Merge commit '3a181ad6d3977502734f83f9464bbc7dfb64412d' into HEAD

aefe8b4

Merge branch 'main' into HEAD

33195b1

r/aws_appmesh_virtual_router: Alphabetize attributes.

1ae3d0f

r/aws_appmesh_virtual_router: Tidy up resource Create, Update and Del…

fd47b31

…ete.

r/aws_appmesh_virtual_router: Tidy up resource Read.

4c25fde

r/aws_appmesh_virtual_router: Tidy up acceptance tests.

b71b24b

Correct CHANGELOG entry.

904192a

Use 'resource.ComposeAggregateTestCheckFunc'.

5b24de5

ewbankkit added 7 commits March 24, 2023 12:34

r/aws_appmesh_gateway_route: Tidy up resource Create, Update and Delete.

16f919b

r/aws_appmesh_gateway_route: Tidy up resource Read.

01e67d4

r/aws_appmesh_gateway_route: Tidy up acceptance tests.

af8869f

d/aws_appmesh_route: Cosmetics.

83635c4

d/aws_appmesh_gateway_route: New data source.

c9098e3

Tweak CHANGELOG entry.

360df73

github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. labels Mar 24, 2023

ewbankkit added 12 commits March 24, 2023 14:35

Fix terrafmt error.

e2e43c3

Fix terrafmt error in documentation.

73912de

Fix terrafmt error.

7a4af68

r/aws_appmesh_virtual_router: 'spec.listener' is Optional.

cec988d

ewbankkit approved these changes Mar 25, 2023

View reviewed changes

ewbankkit merged commit bfa0aa5 into hashicorp:main Mar 27, 2023

github-actions bot added this to the v4.61.0 milestone Mar 27, 2023

ewbankkit mentioned this pull request Mar 27, 2023

Fix CHANGELOG entry #30275

Merged

benmurden deleted the vgw-ports branch March 28, 2023 00:14

github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add App Mesh Virtual Gateway Target Ports #29064

Add App Mesh Virtual Gateway Target Ports #29064

benmurden commented Jan 24, 2023 •

edited by ewbankkit

github-actions bot commented Jan 24, 2023

Fmowers left a comment

benmurden commented Mar 2, 2023

ewbankkit left a comment

ewbankkit commented Mar 25, 2023

github-actions bot commented Mar 30, 2023

github-actions bot commented May 1, 2023

Add App Mesh Virtual Gateway Target Ports #29064

Add App Mesh Virtual Gateway Target Ports #29064

Conversation

benmurden commented Jan 24, 2023 • edited by ewbankkit

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jan 24, 2023

Community Note

Fmowers left a comment

Choose a reason for hiding this comment

benmurden commented Mar 2, 2023

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Mar 25, 2023

github-actions bot commented Mar 30, 2023

github-actions bot commented May 1, 2023

benmurden commented Jan 24, 2023 •

edited by ewbankkit