Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: aws_route53domains_ds_association for AssociateDelegationSignerToDomain #28749

Closed
bryceml opened this issue Jan 6, 2023 · 11 comments · Fixed by #35487
Closed
Labels
new-resource Introduces a new resource. service/route53domains Issues and PRs that pertain to the route53domains service.
Milestone

Comments

@bryceml
Copy link

bryceml commented Jan 6, 2023

Description

https://docs.aws.amazon.com/Route53/latest/APIReference/API_domains_AssociateDelegationSignerToDomain.html

https://awsapichanges.info/archive/changes/8c3630-route53domains.html

This was released recently, it would be nice if there were a way to use it through terraform. Not sure if it's better as its own resource, or if it's fine as part of the aws_route53domains_registered_domain resource. Since you can have multiple keys I'm guessing it would be better as it's own resource.

Requested Resource(s) and/or Data Source(s)

  • aws_route53domains_ds_association

Potential Terraform Configuration

resource "aws_route53domains_ds_association" "example" {
  domain_name = aws_route53domains_registered_domain.example.domain_name
  algorithm   = aws_route53_key_signing_key.example.signing_algorithm_type # default value of 13
  flags       = aws_route53_key_signing_key.example.flag # default value of 257
  public_key  = aws_route53_key_signing_key.example.public_key
}

References

https://docs.aws.amazon.com/Route53/latest/APIReference/API_domains_AssociateDelegationSignerToDomain.html

https://awsapichanges.info/archive/changes/8c3630-route53domains.html

Would you like to implement a fix?

No

@bryceml bryceml added the needs-triage Waiting for first response or review from a maintainer. label Jan 6, 2023
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/route53domains Issues and PRs that pertain to the route53domains service. label Jan 6, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2023
@Szasza
Copy link
Contributor

Szasza commented Feb 18, 2023

Hi @bryceml ,

I would be interested in working on this issue.

@bryceml
Copy link
Author

bryceml commented Mar 15, 2023

@Szasza good to hear. Have you made any progress so far?

@Szasza
Copy link
Contributor

Szasza commented Jul 19, 2023

@bryceml sorry for the delayed response, life happened. I will get to it in the next few days.

@Szasza
Copy link
Contributor

Szasza commented Jul 24, 2023

@bryceml I have started working on the resource and is making good progress. However I will be AFK for a month from the end of the week. There is a good chance that I won't be able to open the PR beforehand.

@seanseth7
Copy link
Contributor

@Szasza Is there any chance that you'll be putting up a PR soon? I could be interested in implementing this as my team would benefit from this resource in a feature we're working on.

@Szasza
Copy link
Contributor

Szasza commented Sep 21, 2023

@seanseth7 my ETA for a PR would be sometime mid-October. Please feel free to implement it if you need it sooner, however please let me know if so, so there is no double-work done.

@seanseth7
Copy link
Contributor

@Szasza Thanks for the quick response! I'll be sure to let you know if I decide to move forward with implementing myself.

@seanseth7
Copy link
Contributor

@Szasza just a heads up that I started working on it in #33596. Not sure when I'll finish it, but hopefully soon. This is my first time contributing so still figuring things out.

Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/route53domains Issues and PRs that pertain to the route53domains service.
Projects
None yet
4 participants