Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route53domains_delegation_signer_record: New resource #35487

Merged
merged 24 commits into from
Jan 25, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 25, 2024

Description

New resource aws_route53domains_delegation_signer_record.

Relations

Closes #33596.
Closes #28749.
Closes #27318.

Output from Acceptance Testing

% ROUTE53DOMAINS_DOMAIN_NAME=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccRoute53Domains_serial/RegisteredDomain/tags' PKG=route53domains
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20  -run=TestAccRoute53Domains_serial/RegisteredDomain/tags -timeout 360m
=== RUN   TestAccRoute53Domains_serial
=== PAUSE TestAccRoute53Domains_serial
=== CONT  TestAccRoute53Domains_serial
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/tags
--- PASS: TestAccRoute53Domains_serial (38.02s)
    --- PASS: TestAccRoute53Domains_serial/RegisteredDomain (38.02s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/tags (38.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	49.556s
% ROUTE53DOMAINS_DOMAIN_NAME=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccRoute53Domains_serial/DelegationSignerRecord/basic' PKG=route53domains
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20  -run=TestAccRoute53Domains_serial/DelegationSignerRecord/basic -timeout 360m
=== RUN   TestAccRoute53Domains_serial
=== PAUSE TestAccRoute53Domains_serial
=== CONT  TestAccRoute53Domains_serial
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord/basic
--- PASS: TestAccRoute53Domains_serial (43.48s)
    --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord (43.48s)
        --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord/basic (43.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	54.091s
% ROUTE53DOMAINS_DOMAIN_NAME=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccRoute53Domains_serial/DelegationSignerRecord/disappears' PKG=route53domains
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20  -run=TestAccRoute53Domains_serial/DelegationSignerRecord/disappears -timeout 360m
=== RUN   TestAccRoute53Domains_serial
=== PAUSE TestAccRoute53Domains_serial
=== CONT  TestAccRoute53Domains_serial
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord
=== RUN   TestAccRoute53Domains_serial/DelegationSignerRecord/disappears
--- PASS: TestAccRoute53Domains_serial (42.49s)
    --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord (42.49s)
        --- PASS: TestAccRoute53Domains_serial/DelegationSignerRecord/disappears (42.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	53.511s

seanseth7 and others added 14 commits October 5, 2023 00:05
% ROUTE53DOMAINS_DOMAIN_NAME=terraform-provider-aws-acctest-acm.com make testacc TESTARGS='-run=TestAccRoute53Domains_serial/RegisteredDomain/tags' PKG=route53domains
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20  -run=TestAccRoute53Domains_serial/RegisteredDomain/tags -timeout 360m
=== RUN   TestAccRoute53Domains_serial
=== PAUSE TestAccRoute53Domains_serial
=== CONT  TestAccRoute53Domains_serial
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain
=== RUN   TestAccRoute53Domains_serial/RegisteredDomain/tags
--- PASS: TestAccRoute53Domains_serial (38.02s)
    --- PASS: TestAccRoute53Domains_serial/RegisteredDomain (38.02s)
        --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/tags (38.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	49.556s
@ewbankkit ewbankkit changed the title r/aws_route53domains_delegation_signer_record: New resource [WIP] r/aws_route53domains_delegation_signer_record: New resource Jan 25, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53domains Issues and PRs that pertain to the route53domains service. generators Relates to code generators. labels Jan 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 25, 2024
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 25, 2024
@ewbankkit ewbankkit changed the title [WIP] r/aws_route53domains_delegation_signer_record: New resource r/aws_route53domains_delegation_signer_record: New resource Jan 25, 2024
internal/framework/base.go Outdated Show resolved Hide resolved
@ewbankkit ewbankkit merged commit ca1fcd0 into main Jan 25, 2024
44 checks passed
@ewbankkit ewbankkit deleted the appian/f-ds-association branch January 25, 2024 21:24
@github-actions github-actions bot added this to the v5.34.0 milestone Jan 25, 2024
github-actions bot pushed a commit that referenced this pull request Jan 25, 2024
Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-resource Introduces a new resource. service/route53domains Issues and PRs that pertain to the route53domains service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants