[New Resource]: `aws_finspace_kx_cluster` #31806

kavan-aws · 2023-06-06T21:18:33Z

Description

This pull request introduces the finspace_kx_cluster resource, along with its associated tests and documentation. This is one component of four new resources being introduced to enable terraform support for FinSpace Managed kdb.

Relations

Relates #22658

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKxCluster PKG=finspace
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_basic'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_basic
=== PAUSE TestAccFinSpaceKxCluster_basic
=== CONT  TestAccFinSpaceKxCluster_basic
--- PASS: TestAccFinSpaceKxCluster_basic (3641.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3665.680s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_disappears
=== PAUSE TestAccFinSpaceKxCluster_disappears
=== RUN   TestAccFinSpaceKxCluster_description
=== PAUSE TestAccFinSpaceKxCluster_description
=== RUN   TestAccFinSpaceKxCluster_database
=== PAUSE TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_description
=== CONT  TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_disappears
--- PASS: TestAccFinSpaceKxCluster_description (4034.09s)
--- PASS: TestAccFinSpaceKxCluster_disappears (4056.67s)
--- PASS: TestAccFinSpaceKxCluster_database (4122.80s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4147.613s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_code
=== PAUSE TestAccFinSpaceKxCluster_code
=== RUN   TestAccFinSpaceKxCluster_rdb
=== PAUSE TestAccFinSpaceKxCluster_rdb
=== RUN   TestAccFinSpaceKxCluster_executionRole
=== PAUSE TestAccFinSpaceKxCluster_executionRole
=== RUN   TestAccFinSpaceKxCluster_initializationScript
=== PAUSE TestAccFinSpaceKxCluster_initializationScript
=== CONT  TestAccFinSpaceKxCluster_code
=== CONT  TestAccFinSpaceKxCluster_executionRole
=== CONT  TestAccFinSpaceKxCluster_rdb
=== CONT  TestAccFinSpaceKxCluster_initializationScript
--- PASS: TestAccFinSpaceKxCluster_initializationScript (3815.94s)
--- PASS: TestAccFinSpaceKxCluster_rdb (3928.16s)
--- PASS: TestAccFinSpaceKxCluster_executionRole (3938.15s)
--- PASS: TestAccFinSpaceKxCluster_code (4386.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4410.964s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_commandLineArgs
=== PAUSE TestAccFinSpaceKxCluster_commandLineArgs
=== RUN   TestAccFinSpaceKxCluster_tags
=== PAUSE TestAccFinSpaceKxCluster_tags
=== CONT  TestAccFinSpaceKxCluster_tags
=== CONT  TestAccFinSpaceKxCluster_commandLineArgs
--- PASS: TestAccFinSpaceKxCluster_commandLineArgs (3771.05s)
--- PASS: TestAccFinSpaceKxCluster_tags (4107.18s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4131.432s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_multiAZ'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_multiAZ
=== PAUSE TestAccFinSpaceKxCluster_multiAZ
=== CONT  TestAccFinSpaceKxCluster_multiAZ
--- PASS: TestAccFinSpaceKxCluster_multiAZ (3987.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	4011.738s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_autoScaling'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_autoScaling
=== PAUSE TestAccFinSpaceKxCluster_autoScaling
=== CONT  TestAccFinSpaceKxCluster_autoScaling
--- PASS: TestAccFinSpaceKxCluster_autoScaling (3645.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3670.399s
...

github-actions · 2023-06-06T21:18:45Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…m-provider-aws into f-finspace_kx_cluster

…r-aws into f-finspace_kx_cluster

…m-provider-aws into f-finspace_kx_cluster

kavan-aws · 2023-06-09T18:30:49Z

Updated acceptance test output:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_basic'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_basic
=== PAUSE TestAccFinSpaceKxCluster_basic
=== CONT  TestAccFinSpaceKxCluster_basic
--- PASS: TestAccFinSpaceKxCluster_basic (3709.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3736.373s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_disappears
=== PAUSE TestAccFinSpaceKxCluster_disappears
=== RUN   TestAccFinSpaceKxCluster_description
=== PAUSE TestAccFinSpaceKxCluster_description
=== RUN   TestAccFinSpaceKxCluster_database
=== PAUSE TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_description
=== CONT  TestAccFinSpaceKxCluster_database
=== CONT  TestAccFinSpaceKxCluster_disappears
--- PASS: TestAccFinSpaceKxCluster_database (3593.13s)
--- PASS: TestAccFinSpaceKxCluster_disappears (3615.51s)
--- PASS: TestAccFinSpaceKxCluster_description (3818.25s)
PASS
ok	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3847.217s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_commandLineArgs'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_commandLineArgs
=== PAUSE TestAccFinSpaceKxCluster_commandLineArgs
=== CONT  TestAccFinSpaceKxCluster_commandLineArgs
--- PASS: TestAccFinSpaceKxCluster_commandLineArgs (3632.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3661.612s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_tags'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_tags
=== PAUSE TestAccFinSpaceKxCluster_tags
=== CONT  TestAccFinSpaceKxCluster_tags
--- PASS: TestAccFinSpaceKxCluster_tags (3735.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3763.310s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_executionRole'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_executionRole
=== PAUSE TestAccFinSpaceKxCluster_executionRole
=== CONT  TestAccFinSpaceKxCluster_executionRole
--- PASS: TestAccFinSpaceKxCluster_executionRole (3725.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3755.084s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster_autoScaling'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_autoScaling
=== PAUSE TestAccFinSpaceKxCluster_autoScaling
=== CONT  TestAccFinSpaceKxCluster_autoScaling
--- PASS: TestAccFinSpaceKxCluster_autoScaling (3544.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3572.281s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/finspace/... -v -count 1 -parallel 20 -run='TestAccFinSpaceKxCluster'  -timeout 180m
=== RUN   TestAccFinSpaceKxCluster_code
=== PAUSE TestAccFinSpaceKxCluster_code
=== RUN   TestAccFinSpaceKxCluster_multiAZ
=== PAUSE TestAccFinSpaceKxCluster_multiAZ
=== RUN   TestAccFinSpaceKxCluster_rdb
=== PAUSE TestAccFinSpaceKxCluster_rdb
=== RUN   TestAccFinSpaceKxCluster_initializationScript
=== PAUSE TestAccFinSpaceKxCluster_initializationScript
=== CONT  TestAccFinSpaceKxCluster_code
=== CONT  TestAccFinSpaceKxCluster_rdb
=== CONT  TestAccFinSpaceKxCluster_initializationScript
=== CONT  TestAccFinSpaceKxCluster_multiAZ
--- PASS: TestAccFinSpaceKxCluster_rdb (3667.63s)
--- PASS: TestAccFinSpaceKxCluster_multiAZ (3672.52s)
--- PASS: TestAccFinSpaceKxCluster_code (3815.89s)
--- PASS: TestAccFinSpaceKxCluster_initializationScript (3858.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/finspace	3888.621s

jar-b

LGTM 🎉

jar-b · 2023-06-09T18:48:03Z

Thanks for your contribution, @kavan-aws! 🥇

github-actions · 2023-06-09T20:07:50Z

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-07-10T02:26:06Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

kavan-aws and others added 2 commits June 6, 2023 16:32

Adds finspace_kx_cluster resource

d7e875a

Merge branch 'hashicorp:main' into f-finspace_kx_cluster

62efb12

kavan-aws and others added 3 commits June 7, 2023 01:29

Formatting fixes to cluster

884db48

Merge branch 'hashicorp:main' into f-finspace_kx_cluster

78730a4

Merge branch 'f-finspace_kx_cluster' of github.com:kavan-aws/terrafor…

a0e4d5c

…m-provider-aws into f-finspace_kx_cluster

jar-b added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 7, 2023

kavan-aws and others added 8 commits June 7, 2023 10:55

Merge branch 'hashicorp:main' into f-finspace_kx_cluster

fc99a4b

Merge branch 'hashicorp:main' into f-finspace_kx_cluster

9800814

Formatting fixes for kx cluster

b48b61a

Merge branch 'hashicorp:main' into f-finspace_kx_cluster

dc5d6ba

Formatting fixes for kx cluster tests and docs

045b1f3

Merge branch 'hashicorp:main' into f-finspace_kx_cluster

fd2bac8

Update kx_cluster_test.go

4c0555f

Update finspace_kx_cluster.html.markdown

a7a6009

jar-b changed the title ~~F finspace kx cluster~~ [New Resource]: aws_finspace_kx_cluster Jun 8, 2023

Resolve merge conflicts

892f0ee

github-actions bot added the tags Pertains to resource tagging. label Jun 8, 2023

Merge branch 'main' of https://github.com/hashicorp/terraform-provide…

b2b0853

…r-aws into f-finspace_kx_cluster

github-actions bot removed generators Relates to code generators. tags Pertains to resource tagging. labels Jun 8, 2023

Ran generate.go

e118041

github-actions bot added the generators Relates to code generators. label Jun 8, 2023

jar-b and others added 20 commits June 8, 2023 12:55

chore: changelog

2ebbd14

Merge branch 'main' into f-finspace_kx_cluster

899b457

r/aws_finspace_kx_cluster: alphabetize attributes

7d4447f

r/aws_finspace_kx_cluster: crud handlers return diags

6bb4317

r/aws_finspace_kx_cluster: allow tag only updates

283da08

r/aws_finspace_kx_cluster: find by id to support import

fc66178

r/aws_finspace_kx_cluster: import support

1c9ffbc

r/aws_finspace_kx_cluster(docs): use standard tags/tags_all descriptions

04fea0f

r/aws_finspace_kx_cluster(docs): alphabetize

0665647

r/aws_finspace_kx_cluster(test): add ctx to check funcs

7c3cc44

r/aws_finspace_kx_cluster(test): add base config

ebffb85

r/aws_finspace_kx_cluster(lint): unconvert

2d1bff1

r/aws_finspace_kx_cluster(test): tags update

56775a6

r/aws_finspace_kx_cluster(lint): avoid hardcoded partition

4695069

Add code.zip for customer code tests

b464ae0

Merge branch 'f-finspace_kx_cluster' of github.com:kavan-aws/terrafor…

b10e06b

…m-provider-aws into f-finspace_kx_cluster

Minor fix to set id

fa8caca

r/aws_finspace_kx_cluster: use environment id from resource id on read

ad974f9

r/aws_finspace_kx_cluster: no force new on tag updates

c4e8b6b

Set environment id in read function

2b38493

jar-b self-assigned this Jun 9, 2023

jar-b approved these changes Jun 9, 2023

View reviewed changes

jar-b merged commit 23e4215 into hashicorp:main Jun 9, 2023
45 checks passed

github-actions bot added this to the v5.2.0 milestone Jun 9, 2023

kavan-aws mentioned this pull request Jun 14, 2023

docs: Quick fix to finspace_kx_cluster documentation #31990

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New Resource]: `aws_finspace_kx_cluster` #31806

[New Resource]: `aws_finspace_kx_cluster` #31806

kavan-aws commented Jun 6, 2023

github-actions bot commented Jun 6, 2023

kavan-aws commented Jun 9, 2023

jar-b left a comment

jar-b commented Jun 9, 2023

github-actions bot commented Jun 9, 2023

github-actions bot commented Jul 10, 2023

[New Resource]: aws_finspace_kx_cluster #31806

[New Resource]: aws_finspace_kx_cluster #31806

Conversation

kavan-aws commented Jun 6, 2023

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Jun 6, 2023

Community Note

kavan-aws commented Jun 9, 2023

jar-b left a comment

Choose a reason for hiding this comment

jar-b commented Jun 9, 2023

github-actions bot commented Jun 9, 2023

github-actions bot commented Jul 10, 2023

[New Resource]: `aws_finspace_kx_cluster` #31806

[New Resource]: `aws_finspace_kx_cluster` #31806