Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Quick fix to finspace_kx_cluster documentation #31990

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

kavan-aws
Copy link
Contributor

Description

Minor update to finspace_kx_cluster documentation. This resource no longer takes a port as an optional parameter and the parameter was removed from the documentation earlier but hasn't yet been updated in the description for the larger capacity_configuration construct.

Relations

Relates #31806

References

AWS user guide documentation for finspace kx cluster: https://docs.aws.amazon.com/finspace/latest/userguide/create-kdb-clusters.html

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/finspace Issues and PRs that pertain to the finspace service. needs-triage Waiting for first response or review from a maintainer. labels Jun 14, 2023
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much for your contribution! I'll get this merged once the checks finish up 🚀

@justinretzolk justinretzolk merged commit 5054d51 into hashicorp:main Jun 14, 2023
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jun 14, 2023
@github-actions github-actions bot added this to the v5.4.0 milestone Jun 14, 2023
@github-actions
Copy link

This functionality has been released in v5.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@AdamTylerLynch AdamTylerLynch added the partner Contribution from a partner. label Jun 19, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/finspace Issues and PRs that pertain to the finspace service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants