Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: current Organization ID (0-xxxxxxxxxx) does not match (r-xxxx) #33083

Closed
dannyibishev opened this issue Aug 18, 2023 · 4 comments · Fixed by #33091
Closed

[Bug]: current Organization ID (0-xxxxxxxxxx) does not match (r-xxxx) #33083

dannyibishev opened this issue Aug 18, 2023 · 4 comments · Fixed by #33091
Assignees
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/organizations Issues and PRs that pertain to the organizations service.
Milestone

Comments

@dannyibishev
Copy link

Terraform Core Version

1.5.5

AWS Provider Version

5.13.0

Affected Resource(s)

I bumped the AWS provider on my workspace from 5.12.0 to 5.13.0 and was greeted by an error for the aws_organizations_organization resource.

The error

Screenshot 2023-08-18 at 11 34 24

I believe this to be a bug that was introduced possibly by commit #31796

resource affected

  • aws_organizations_organization

Expected Behavior

What

There should have been no change in the id within the state for the affected resource.

Why

I have not made any changes myself other than bump the AWS provider.

Actual Behavior

The error provided from earlier

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_organizations_organization" "org" {
  aws_service_access_principals = ["account.amazonaws.com", "cloudtrail.amazonaws.com"]
  feature_set                   = "ALL"
}

Steps to Reproduce

  1. Provision a aws_organizations_organization resource on aws provider 5.12.0.
  2. Apply the resource.
  3. Bump the aws provider to 5.13.0.
  4. Run a plan.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@dannyibishev dannyibishev added the bug Addresses a defect in current functionality. label Aug 18, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/organizations Issues and PRs that pertain to the organizations service. label Aug 18, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 18, 2023
@ewbankkit ewbankkit added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 18, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 18, 2023
@ewbankkit
Copy link
Contributor

@dannyibishev Thanks for raising this issue 👏.
Looking at the code, my guess is that the aws_organizations_organization resource was previously imported with the r-xxxx root identifier and that became the resource's id in state. Since the import ID wasn't checked prior to #31796, this was a valid scenario.
I've marked this bug as a regression -- I'll move the id-checking code into the importer rather than resource Read.

@github-actions
Copy link

This functionality has been released in v5.13.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Aug 18, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/organizations Issues and PRs that pertain to the organizations service.
Projects
None yet
3 participants