Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_imagebuilder_image #33213

Closed
raghavanrrs opened this issue Aug 29, 2023 · 4 comments · Fixed by #34049
Closed

[Enhancement]: aws_imagebuilder_image #33213

raghavanrrs opened this issue Aug 29, 2023 · 4 comments · Fixed by #34049
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Milestone

Comments

@raghavanrrs
Copy link

Description

Enhancement to existing resource aws_imagebuilder_image

Would like to have an option to enable image scanning argument ref.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/imagebuilder_image

boto3 and aws cli api currently supports the arguments config.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/imagebuilder/client/create_image.html

Affected Resource(s) and/or Data Source(s)

aws_imagebuilder_image

Potential Terraform Configuration

resource "aws_imagebuilder_image" "example" {
  distribution_configuration_arn   = aws_imagebuilder_distribution_configuration.example.arn
  image_recipe_arn                 = aws_imagebuilder_image_recipe.example.arn
  infrastructure_configuration_arn = aws_imagebuilder_infrastructure_configuration.example.arn
  imageScanningConfiguration {
    imageScanningEnabled = <bool>
    ecrConfiguration {
     repositoryName = <string> "my-ecr-repo"
     containerTags = <list(string)> ["string1", "string2", "string3"]
    }
  }

}

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/imagebuilder/client/create_image.html

Would you like to implement a fix?

None

@raghavanrrs raghavanrrs added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 29, 2023
@github-actions github-actions bot added the service/imagebuilder Issues and PRs that pertain to the imagebuilder service. label Aug 29, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 29, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2023
@DanielRieske
Copy link
Contributor

Seems like a great issue to pick up, i'll gladly pick this up and will add the PR shortly.

@github-actions
Copy link

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/imagebuilder Issues and PRs that pertain to the imagebuilder service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants