Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_config_config_rule: add evaluation_mode #34033

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Oct 20, 2023

Description

Relations

Closes #33532

References

Output from Acceptance Testing

$ make testacc PKG=configservice TESTARGS='-run=TestAccConfigService_serial/^ConfigRule/$'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/^ConfigRule/ -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConfigRule
=== RUN   TestAccConfigService_serial/ConfigRule/disappears
=== RUN   TestAccConfigService_serial/ConfigRule/ownerAws
=== RUN   TestAccConfigService_serial/ConfigRule/customPolicy
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagValue
=== RUN   TestAccConfigService_serial/ConfigRule/tags
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty
=== RUN   TestAccConfigService_serial/ConfigRule/basic
=== RUN   TestAccConfigService_serial/ConfigRule/customlambda
=== RUN   TestAccConfigService_serial/ConfigRule/evaluationMode
=== RUN   TestAccConfigService_serial/ConfigRule/scopeTagKey
--- PASS: TestAccConfigService_serial (2010.56s)
    --- PASS: TestAccConfigService_serial/ConfigRule (2010.56s)
        --- PASS: TestAccConfigService_serial/ConfigRule/disappears (160.43s)
        --- PASS: TestAccConfigService_serial/ConfigRule/ownerAws (161.11s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customPolicy (159.02s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagValue (217.73s)
        --- PASS: TestAccConfigService_serial/ConfigRule/tags (286.92s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty (154.99s)
        --- PASS: TestAccConfigService_serial/ConfigRule/basic (154.75s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customlambda (279.08s)
        --- PASS: TestAccConfigService_serial/ConfigRule/evaluationMode (218.40s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKey (218.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	2013.706s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/configservice Issues and PRs that pertain to the configservice service. labels Oct 20, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 20, 2023
@johnsonaj johnsonaj added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 20, 2023
@johnsonaj johnsonaj marked this pull request as ready for review October 20, 2023 19:13
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConfigService_serial/^ConfigRule$$/basic\|TestAccConfigService_serial/^ConfigRule$$/evaluationMode' PKG=configservice                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20  -run=TestAccConfigService_serial/^ConfigRule$/basic\|TestAccConfigService_serial/^ConfigRule$/evaluationMode -timeout 360m
=== RUN   TestAccConfigService_serial
=== PAUSE TestAccConfigService_serial
=== CONT  TestAccConfigService_serial
=== RUN   TestAccConfigService_serial/ConfigRule
=== RUN   TestAccConfigService_serial/ConfigRule/basic
=== RUN   TestAccConfigService_serial/ConfigRule/evaluationMode
--- PASS: TestAccConfigService_serial (208.60s)
    --- PASS: TestAccConfigService_serial/ConfigRule (208.59s)
        --- PASS: TestAccConfigService_serial/ConfigRule/basic (106.22s)
        --- PASS: TestAccConfigService_serial/ConfigRule/evaluationMode (102.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	222.728s

@johnsonaj johnsonaj merged commit 4da499e into main Oct 20, 2023
60 checks passed
@johnsonaj johnsonaj deleted the f-config_config_rule_evaluation_mode branch October 20, 2023 20:39
@github-actions github-actions bot added this to the v5.23.0 milestone Oct 20, 2023
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
@github-actions
Copy link

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/configservice Issues and PRs that pertain to the configservice service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_config_config_rule add Support for Evaluation Modes
2 participants