Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_feature_group - add args #34283

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #32901

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerFeatureGroup_serial PKG=sagemaker

    --- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfig_ttlDuration (206.64s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/storageType (981.96s)

Copy link

github-actions bot commented Nov 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 6, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Nov 6, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 6, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review November 6, 2023 22:02
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerFeatureGroup_serial' PKG=sagemaker 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20  -run=TestAccSageMakerFeatureGroup_serial -timeout 360m
=== RUN   TestAccSageMakerFeatureGroup_serial
=== PAUSE TestAccSageMakerFeatureGroup_serial
=== CONT  TestAccSageMakerFeatureGroup_serial
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog
=== RUN   TestAccSageMakerFeatureGroup_serial/onlineConfig_TTLDuration
=== RUN   TestAccSageMakerFeatureGroup_serial/basic
=== RUN   TestAccSageMakerFeatureGroup_serial/storageType
=== RUN   TestAccSageMakerFeatureGroup_serial/multipleFeatures
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_format
    feature_group_test.go:342: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for SageMaker Feature Group (tf-acc-test-3879383729371267353) to create: unexpected state 'CreateFailed', wanted target 'Created'. last error: Exception: {User: arn:aws:sts::123456789012:assumed-role/tf-acc-test-3879383729371267353/SageMakerFeatureStore4655599647252957269 is not authorized to perform: glue:GetTable on resource: arn:aws:glue:us-west-2:123456789012:catalog because no identity-based policy allows the glue:GetTable action (Service: Glue, Status Code: 400, Request ID: b9e1000a-1a3d-4ab1-b688-ba79fd4f73c9)}. Please ensure given RoleArn has 'AmazonSageMakerFeatureStoreAccess' managed policy attached, with access to get and update Glue table in the AWS account, read and write Iceberg objects in S3, with principal 'sagemaker.amazonaws.com' as a trusted entity. If a KMS Key is provided for the Offline Store, also ensure that RoleArn is allowed to perform 'kms:GenerateDataKey' and 'kms:Decrypt' actions on it.
        
          with aws_sagemaker_feature_group.test,
          on terraform_plugin_test.tf line 47, in resource "aws_sagemaker_feature_group" "test":
          47: resource "aws_sagemaker_feature_group" "test" {
        
=== RUN   TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig
=== RUN   TestAccSageMakerFeatureGroup_serial/tags
=== RUN   TestAccSageMakerFeatureGroup_serial/description
=== RUN   TestAccSageMakerFeatureGroup_serial/disappears
=== RUN   TestAccSageMakerFeatureGroup_serial/offlineConfig_basic
--- FAIL: TestAccSageMakerFeatureGroup_serial (1676.91s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_createCatalog (86.04s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_providedCatalog (83.02s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfig_TTLDuration (65.84s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/basic (49.24s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/storageType (934.58s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/multipleFeatures (49.47s)
    --- FAIL: TestAccSageMakerFeatureGroup_serial/offlineConfig_format (83.77s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/onlineConfigSecurityConfig (49.85s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/tags (82.40s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/description (39.81s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/disappears (68.59s)
    --- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_basic (84.29s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	1682.568s
FAIL
make: *** [testacc] Error 1

Failure is unrelated to this change.

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bc8e2e1 into hashicorp:main Nov 8, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 8, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support to time to live (TTL) in SageMaker online Feature Store
2 participants