Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support to time to live (TTL) in SageMaker online Feature Store #32901

Closed
danilko opened this issue Aug 8, 2023 · 4 comments · Fixed by #34283
Closed

[Enhancement]: Add support to time to live (TTL) in SageMaker online Feature Store #32901

danilko opened this issue Aug 8, 2023 · 4 comments · Fixed by #34283
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@danilko
Copy link

danilko commented Aug 8, 2023

Description

Requesting that Terraform add support for time to live (TTL) in SageMaker online Feature Store. SageMaker Feature Store added support for setting up TTL at feature group level for online Feature Store 06/30/2023 (announced here).
Docs are (here).

Thanks.

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_feature_group

Potential Terraform Configuration

resource "aws_sagemaker_feature_group" "customer_feature_group" {
  feature_group_name             = "fg1"
  record_identifier_feature_name = "customer_id"
  event_time_feature_name        = "at"
  role_arn                       = aws_iam_role.feature_group_role.arn
  feature_definition {
    feature_name = "customer_id"
    feature_type = "String"
  } ...
  online_store_config {
    enable_online_store = true
     ttl_duration {
       unit           = "Weeks"
       value          = 4
    }
  } ...
}

References

Docs are (here).

Above code sample is provided based on how AWS Pyhton SDK's code will behave

import boto3

sagemaker_client = boto3.client("sagemaker")
feature_group_name = '<YOUR_FEATURE_GROUP_NAME>'

sagemaker_client.update_feature_group(
    FeatureGroupName=feature_group_name,
    OnlineStoreConfig={
        TtlDuration:{
            Unit: "Weeks",
            Value: 4
        }
    }
)

Would you like to implement a fix?

None

@danilko danilko added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sagemaker Issues and PRs that pertain to the sagemaker service. label Aug 8, 2023
@DrFaust92
Copy link
Collaborator

looking into this

@DrFaust92 DrFaust92 self-assigned this Nov 5, 2023
@github-actions github-actions bot added this to the v5.25.0 milestone Nov 8, 2023
Copy link

This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants