Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: New, undocumented response from the Managed Grafana API #34417

Closed
zhimsel opened this issue Nov 15, 2023 · 6 comments · Fixed by #34105
Closed

[Bug]: New, undocumented response from the Managed Grafana API #34417

zhimsel opened this issue Nov 15, 2023 · 6 comments · Fixed by #34105
Labels
bug Addresses a defect in current functionality. service/grafana Issues and PRs that pertain to the grafana service.
Milestone

Comments

@zhimsel
Copy link

zhimsel commented Nov 15, 2023

Terraform Core Version

1.5.5,1.5.7

AWS Provider Version

5.23.1

Affected Resource(s)

Expected Behavior

No drift when no changes have been made

Actual Behavior

Persistent drift for the configuration argument. The DescribeWorkspaceConfiguration API action now responds with additional JSON fields:

 {
+  "plugins": {
+    "pluginAdminEnabled": false
+  }
   "unifiedAlerting": {
     "enabled": true|false
   }
 }

It appears that the new field is always false and there is no corresponding setting in the console for this new option.

Also, applying the drift (i.e. calling UpdateWorkspaceConfiguration with thew new field) "updates" the workspace, but does not actually change anything; the drift continues to appear in subsequent plans.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

n/a

Steps to Reproduce

nothing, just plan your aws_grafana_workspace after today

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

@zhimsel zhimsel added the bug Addresses a defect in current functionality. label Nov 15, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2023
@ewbankkit ewbankkit added the service/grafana Issues and PRs that pertain to the grafana service. label Nov 15, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2023
@ewbankkit
Copy link
Contributor

I can reproduce in acceptance tests:

% make testacc TESTARGS='-run=TestAccGrafana_serial/Workspace/configuration' PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20  -run=TestAccGrafana_serial/Workspace/configuration -timeout 360m
=== RUN   TestAccGrafana_serial
=== PAUSE TestAccGrafana_serial
=== CONT  TestAccGrafana_serial
=== RUN   TestAccGrafana_serial/Workspace
=== RUN   TestAccGrafana_serial/Workspace/configuration
    workspace_test.go:446: Step 1/3 error: Check failed: 1 error occurred:
        	* Check 2/2 error: aws_grafana_workspace.test: Attribute 'configuration' expected "{\"unifiedAlerting\":{\"enabled\":true}}", got "{\"unifiedAlerting\":{\"enabled\":true},\"plugins\":{\"pluginAdminEnabled\":false}}"
        
--- FAIL: TestAccGrafana_serial (310.45s)
    --- FAIL: TestAccGrafana_serial/Workspace (310.45s)
        --- FAIL: TestAccGrafana_serial/Workspace/configuration (310.45s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	315.995s
FAIL
make: *** [testacc] Error 1

@ewbankkit
Copy link
Contributor

Grafana community plugins announcement.

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 16, 2023

I have verified that after the GA of the plugins functionality you can add JSON like

"plugins": {"pluginAdminEnabled": false}

to configuration to suppress the diff.

@github-actions github-actions bot added this to the v5.26.0 milestone Nov 16, 2023
Copy link

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/grafana Issues and PRs that pertain to the grafana service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants