Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for Google BigQuery glue connection in terraform #34575

Open
justin-hong1 opened this issue Nov 27, 2023 · 9 comments · May be fixed by #37731
Open

[Enhancement]: Add support for Google BigQuery glue connection in terraform #34575

justin-hong1 opened this issue Nov 27, 2023 · 9 comments · May be fixed by #37731
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.

Comments

@justin-hong1
Copy link

Description

Add support for the new Google BigQuery glue connector in terraform.

https://aws.amazon.com/about-aws/whats-new/2023/10/aws-glue-apache-spark-connectivity-google-bigquery/

Affected Resource(s) and/or Data Source(s)

aws_glue_connection

Potential Terraform Configuration

resource "aws_glue_connection" "bigquery_connection" {
  connection_type = "bigquery"

  connection_properties = {
    SECRET_ID           = aws_secretsmanager_secret.example_secret.name
  }

  name = "bigquery_connection"
}

References

blog: https://aws.amazon.com/about-aws/whats-new/2023/10/aws-glue-apache-spark-connectivity-google-bigquery/

docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/glue_connection

Would you like to implement a fix?

None

@justin-hong1 justin-hong1 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 27, 2023
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/glue Issues and PRs that pertain to the glue service. label Nov 27, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 27, 2023
@bschaatsbergen
Copy link
Member

bschaatsbergen commented Nov 27, 2023

I'll pick this up! (probably just bumping SDK version, docs and checking whether there's a validateFunc on input values)

@bschaatsbergen bschaatsbergen self-assigned this Nov 27, 2023
@bschaatsbergen bschaatsbergen removed the needs-triage Waiting for first response or review from a maintainer. label Nov 27, 2023
@DrFaust92
Copy link
Collaborator

Similar to #32663

@dponkin
Copy link

dponkin commented Apr 9, 2024

The connection can be configured manually and then imported into Terraform, provided that you ignore the type and the properties:

resource "aws_glue_connection" "bigquery_connection" {
  name = "bigquery-connection"

  lifecycle {
    ignore_changes = [connection_type, connection_properties]
  }
}

The actual state of the connection, as generated by Terraform when you remove ignore_changes, looks like this:

resource "aws_glue_connection" "bigquery_connection" {
  name = "bigquery-connection"

  connection_type = "BIGQUERY"
  connection_properties = {
    "SparkProperties" = jsonencode({
      "secretId" = "${var.secretid}"
    })
  }
}

@dponkin
Copy link

dponkin commented Apr 10, 2024

@bschaatsbergen Do you mind if I submit a PR for this?

@bschaatsbergen
Copy link
Member

@bschaatsbergen Do you mind if I submit a PR for this?

Go for it! 😎

@bschaatsbergen bschaatsbergen removed their assignment Apr 10, 2024
@dponkin
Copy link

dponkin commented Apr 15, 2024

This connection type is not supported by aws-sdk-go itself.

Considering that GA for v1 ends in a few months, I feel like it'd make more sense to use the opportunity to upgrade the connection module to aws-sdk-go-v2.

@cylik93
Copy link

cylik93 commented Apr 23, 2024

@dponkin
Is this implemented yet?

@ksauzz
Copy link

ksauzz commented Apr 30, 2024

According to my investigation, even if we upgrade the connection module to aws-sdk-go-v2, it seems any aws SDKs don't support BIGQuery connection type because the API model file is too old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
6 participants