feat: Add support for third-party connection types to aws_glue_connection #37731
+563
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add support for the following connection types:
AZURECOSMOS
,AZURESQL
,BIGQUERY
,OPENSEARCH
,SNOWFLAKE
. These types were confirmed by AWS support to be supported but not fully documented. They are also not available in types and enums in various SDKs, including the AWS Go SDK v2 which the Terraform AWS Provider uses.The approach to add these connection types is to check whether they are in the SDK enum, and add them if they are not. This provides some level of compatibility for when the enum eventually gets updated before the code is removed for good. In addition, a new value
SparkProperties
is needed for the enum forconnection_properties
. It is also not documented but supported by the API. Each connection type make require different properties within a JSON object that is provided as the value forSparkProperties
. I am not sure how to best document them, so I've added a full example for each type in the documentation.Relations
Closes #37233
Closes #34575
Closes #32663
References
Examined network traces for CreateConnection requests made in the Console to determine what properties are needed in the JSON object for
SparkProperties
.Output from Acceptance Testing