Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lb does not support all loadbalancer attributes #3511

Closed
ameir opened this issue Feb 24, 2018 · 7 comments · Fixed by #3609
Closed

aws_lb does not support all loadbalancer attributes #3511

ameir opened this issue Feb 24, 2018 · 7 comments · Fixed by #3609
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.

Comments

@ameir
Copy link
Contributor

ameir commented Feb 24, 2018

The aws_lb resource support access logs and deletion protection, but there are a few other attributes that are not exposed via this provider [0][1]. This resource exposes the two available attributes as top-level arguments, while, for example, CloudFormation asks for a list of attributes [2], which I think is more flexible, although maybe this resource tries to keep things similar to aws_elb.

I need to enable cross-zone load balancing and adjust the timeout, but this must currently be done out-of-band.

Affected Resource(s)

  • aws_lb

References

0: https://www.terraform.io/docs/providers/aws/r/lb.html
1:
https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_LoadBalancerAttribute.html
2: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-loadbalancer.html#cfn-elasticloadbalancingv2-loadbalancer-loadbalancerattributes

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Feb 24, 2018
@bflad
Copy link
Contributor

bflad commented Mar 2, 2018

Support for NLB cross-zone load balancing has been merged into master and will release with v1.11.0 of the AWS provider, likely in a week. It looks like @appilon and @mpilar will be working out HTTP/2 in a followup PR. 😄

@ameir
Copy link
Contributor Author

ameir commented Mar 3, 2018

Thanks for the hard work, everyone!

@octplane
Copy link

Hello,

In our tests:

  • Creating an ALB with enable_http2 set to false does not work: it creates an ALB with the flag set to true. The state contains "enable_http2": "false".
  • Modifying the value in the terraform code trigger the change up to AWS
  • Modifying the value in AWS has no consequence: terraform does not attempt to fix that.
Terraform v0.11.2
+ provider.aws v1.11.0

@juissi-t
Copy link

We seem to be having exactly the same issue as @octplane is having. Should this ticket be re-opened or a new one created?

@appilon
Copy link
Contributor

appilon commented Mar 19, 2018

I've traced through the code and think I've found the issue, I should have a PR with a fix up soon

@appilon
Copy link
Contributor

appilon commented Mar 20, 2018

The bug appears to be a bit more elusive than I thought. Working on a fix. I have made a new issue to track progress.
#3848

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants