Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELBv2 attributes do not configure properly on create #3848

Closed
appilon opened this issue Mar 20, 2018 · 4 comments · Fixed by #3854
Closed

ELBv2 attributes do not configure properly on create #3848

appilon opened this issue Mar 20, 2018 · 4 comments · Fixed by #3854
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@appilon
Copy link
Contributor

appilon commented Mar 20, 2018

Load Balancer attributes do not appear to be setting their values correctly on create.

Terraform Version

Terraform v0.11.2
+ provider.aws v1.11.0

Affected Resource(s)

  • aws_lb

Terraform Configuration Files

resource "aws_lb" "lb_test" {
  name            = "test"
  internal        = true
  security_groups = ["${aws_security_group.alb_test.id}"]
  subnets         = ["${aws_subnet.alb_test.*.id}"]
  
  idle_timeout = 30
  enable_deletion_protection = false

  enable_http2 = false

  tags {
    Name = "TestAccAWSALB_basic"
  }
}

variable "subnets" {
  default = ["10.0.1.0/24", "10.0.2.0/24"]
  type    = "list"
}

data "aws_availability_zones" "available" {}

resource "aws_vpc" "alb_test" {
  cidr_block = "10.0.0.0/16"

  tags {
    Name = "terraform-testacc-lb-basic"
  }
}

resource "aws_subnet" "alb_test" {
  count                   = 2
  vpc_id                  = "${aws_vpc.alb_test.id}"
  cidr_block              = "${element(var.subnets, count.index)}"
  map_public_ip_on_launch = true
  availability_zone       = "${element(data.aws_availability_zones.available.names, count.index)}"

  tags {
    Name = "tf-acc-lb-basic-${count.index}"
  }
}

resource "aws_security_group" "alb_test" {
  name        = "allow_all_alb_test"
  description = "Used for ALB Testing"
  vpc_id      = "${aws_vpc.alb_test.id}"

  ingress {
    from_port   = 0
    to_port     = 0
    protocol    = "-1"
    cidr_blocks = ["0.0.0.0/0"]
  }

  egress {
    from_port   = 0
    to_port     = 0
    protocol    = "-1"
    cidr_blocks = ["0.0.0.0/0"]
  }

  tags {
    Name = "TestAccAWSALB_basic"
  }
}

Expected Behavior

Application load balancer created with HTTP/2 disabled

Actual Behavior

Application load balancer has HTTP/2 enabled

Steps to Reproduce

  1. terraform apply

References

@mpilar
Copy link
Contributor

mpilar commented Mar 21, 2018

I will look into this as soon as I have a chance. It's curious because the acceptance tests should be grabbing this.

@appilon
Copy link
Contributor Author

appilon commented Mar 21, 2018

@mpilar I'm actually already working on a fix. I know what the issue is feel I would love a review from you when my PR goes up

@appilon appilon changed the title ELBv2 attributes do configure properly on create ELBv2 attributes do not configure properly on create Mar 21, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Mar 23, 2018
@bflad bflad added this to the v1.13.0 milestone Mar 29, 2018
@bflad
Copy link
Contributor

bflad commented Mar 29, 2018

This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants