Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_devopsguru_notification_channel: fix filters persistent diff #36804

Merged
merged 1 commit into from Apr 9, 2024
Merged

r/aws_devopsguru_notification_channel: fix filters persistent diff #36804

merged 1 commit into from Apr 9, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Apr 9, 2024

Description

This changes the type of the filters.message_types and filters.severities arguments to TypeSet, preventing persistent differences when the AWS API returns elements in a different order than they were sent.

Relations

Depends on #36789
Closes #36731

Output from Acceptance Testing

% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannel/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannel/'  -timeout 360m

--- PASS: TestAccDevOpsGuru_serial (48.85s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannel (37.73s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/disappears (12.13s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/filters (12.83s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/basic (12.77s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource (11.12s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic (11.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 54.578s

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/devopsguru Issues and PRs that pertain to the devopsguru service. labels Apr 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 9, 2024
@jar-b
r/aws_devopsguru_notification_channel: fix filters persistent diff
a607f63 
This changes the type of the `filters.message_types` and `filters.severities` arguments to `TypeSet`, preventing persistent differences when the AWS API returns elements in a different order than they were sent.

```console
% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannel/
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannel/'  -timeout 360m

--- PASS: TestAccDevOpsGuru_serial (48.85s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannel (37.73s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/disappears (12.13s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/filters (12.83s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/basic (12.77s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource (11.12s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannelDataSource/basic (11.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 54.578s
```
@jar-b jar-b force-pushed the b-devopsguru_notification_channel-diff branch from f6557c3 to a607f63 Compare April 9, 2024 14:11
ewbankkit
ewbankkit approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit db83eb8 into main Apr 9, 2024
37 checks passed
@jar-b jar-b deleted the b-devopsguru_notification_channel-diff branch April 9, 2024 16:51
@github-actions github-actions bot added this to the v5.45.0 milestone Apr 9, 2024
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
Update CHANGELOG.md for #36804
da12393
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/devopsguru Issues and PRs that pertain to the devopsguru service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.45.0
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_devopsguru_notification_channel reordering on each deployment even without change
2 participants
@jar-b @ewbankkit