Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_redshift_snapshot_copy: new resource #36810

Merged
merged 2 commits into from Apr 11, 2024
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Apr 9, 2024

Description

This resource will allow practitioners to manage Amazon Redshift cluster snapshot copy configurations with Terraform. This standalone resource will replace the optional snapshot_copy block within the aws_redshift_cluster resource, allowing snapshot copy configurations to be managed independent of the parent cluster.

The snapshot_copy argument within the aws_redshift_cluster resource is now deprecated.

Relations

Closes #36637

References

Output from Acceptance Testing

% make testacc PKG=redshift TESTS=TestAccRedshiftSnapshotCopy_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftSnapshotCopy_'  -timeout 360m

--- PASS: TestAccRedshiftSnapshotCopy_disappears_Cluster (411.83s)
--- PASS: TestAccRedshiftSnapshotCopy_disappears (420.58s)
--- PASS: TestAccRedshiftSnapshotCopy_retentionPeriod (422.03s)
--- PASS: TestAccRedshiftSnapshotCopy_basic (423.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   429.531s

Copy link

github-actions bot commented Apr 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshift Issues and PRs that pertain to the redshift service. generators Relates to code generators. labels Apr 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 9, 2024
@jar-b jar-b added the new-resource Introduces a new resource. label Apr 9, 2024
This resource will allow practitioners to manage Amazon Redshift cluster snapshot copy configurations with Terraform. This standalone resource will replace the optional `snapshot_copy` block within the `aws_redshift_cluster` resource, allowing snapshot copy configurations to be managed independent of the parent cluster.

```console
% make testacc PKG=redshift TESTS=TestAccRedshiftSnapshotCopy_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftSnapshotCopy_'  -timeout 360m

--- PASS: TestAccRedshiftSnapshotCopy_disappears_Cluster (411.83s)
--- PASS: TestAccRedshiftSnapshotCopy_disappears (420.58s)
--- PASS: TestAccRedshiftSnapshotCopy_retentionPeriod (422.03s)
--- PASS: TestAccRedshiftSnapshotCopy_basic (423.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   429.531s
```
This argument is deprecated in favor of the new, standalone `aws_redshift_snapshot_copy` resource.
@jar-b
Copy link
Member Author

jar-b commented Apr 10, 2024

Re-running acceptance tests after making the cluster snapshot_copy argument computed and removing lifecycle.ignore_changes:

% make testacc PKG=redshift TESTS=TestAccRedshiftSnapshotCopy_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/redshift/... -v -count 1 -parallel 20 -run='TestAccRedshiftSnapshotCopy_'  -timeout 360m
=== RUN   TestAccRedshiftSnapshotCopy_basic
=== PAUSE TestAccRedshiftSnapshotCopy_basic
=== RUN   TestAccRedshiftSnapshotCopy_disappears
=== PAUSE TestAccRedshiftSnapshotCopy_disappears
=== RUN   TestAccRedshiftSnapshotCopy_disappears_Cluster
=== PAUSE TestAccRedshiftSnapshotCopy_disappears_Cluster
=== RUN   TestAccRedshiftSnapshotCopy_retentionPeriod
=== PAUSE TestAccRedshiftSnapshotCopy_retentionPeriod
=== CONT  TestAccRedshiftSnapshotCopy_basic
=== CONT  TestAccRedshiftSnapshotCopy_disappears_Cluster
=== CONT  TestAccRedshiftSnapshotCopy_disappears
=== CONT  TestAccRedshiftSnapshotCopy_retentionPeriod
--- PASS: TestAccRedshiftSnapshotCopy_disappears_Cluster (402.67s)
--- PASS: TestAccRedshiftSnapshotCopy_disappears (410.17s)
--- PASS: TestAccRedshiftSnapshotCopy_basic (412.49s)
--- PASS: TestAccRedshiftSnapshotCopy_retentionPeriod (423.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   428.643s

@jar-b jar-b merged commit 8203c4b into main Apr 11, 2024
53 checks passed
@jar-b jar-b deleted the f-redshift_snapshot_copy branch April 11, 2024 15:12
@github-actions github-actions bot added this to the v5.45.0 milestone Apr 11, 2024
github-actions bot pushed a commit that referenced this pull request Apr 11, 2024
Copy link

This functionality has been released in v5.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/redshift Issues and PRs that pertain to the redshift service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_redshift_snapshot_copy
2 participants