Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for KMS Flexible key rotation #36948

Closed
fabio-sv opened this issue Apr 17, 2024 · 5 comments · Fixed by #37140
Closed

[Enhancement]: Add support for KMS Flexible key rotation #36948

fabio-sv opened this issue Apr 17, 2024 · 5 comments · Fixed by #37140
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service.
Milestone

Comments

@fabio-sv
Copy link

fabio-sv commented Apr 17, 2024

Description

Add support for the new flexible automatic KMS key rotation features.

The KMS team has added 3 new features to CMK KMS:

  1. customize the rotation period of a KMS key (from 90 days to 2560 days).
  2. invoke key rotation on demand for CMK KMS keys.
  3. view key rotation history of the given KMS key.

Point no. 2 most likely doesn't make sense to implement, though listing it here for completeness.

Affected Resource(s) and/or Data Source(s)

  • aws_kms_key

Potential Terraform Configuration

resource "aws_kms_key" "a" {
  description             = "My awesome key"
  deletion_window_in_days = 10
  enable_key_rotation     = true
  rotation_period_in_days = 90 # new
}

References

Feature announcement: https://aws.amazon.com/about-aws/whats-new/2024/04/aws-kms-automatic-key-rotation/
Updated CLI docs: https://docs.aws.amazon.com/cli/latest/reference/kms/enable-key-rotation.html

Would you like to implement a fix?

Yes

@fabio-sv fabio-sv added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 17, 2024
@github-actions github-actions bot added the service/kms Issues and PRs that pertain to the kms service. label Apr 17, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 17, 2024
@aristosvo
Copy link
Contributor

As it is a separate API, it probably will be a separate resource.

Probably needs #36178 as well before this new resource can be submitted.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 30, 2024
Copy link

github-actions bot commented May 6, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.49.0 milestone May 6, 2024
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants