Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: AWS SDK for Go v1-compatible Backoff mechanism #37404

Merged
merged 16 commits into from May 9, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 9, 2024

Description

Adds an AWS SDK for Go v1-compatible Backoff mechanism so that retry behavior differences for migrated resources are minimized.

Relations

Closes #37392.

References

Output from Acceptance Testing

% go test -v -run=TestBackoffDelayer ./internal/conns
=== RUN   TestBackoffDelayer
=== PAUSE TestBackoffDelayer
=== CONT  TestBackoffDelayer
    backoff_delayer_test.go:50: 0 v1: 591.423882ms, v2: 738.651297ms v1compat: 897.273642ms
    backoff_delayer_test.go:50: 1 v1: 1.01567116s, v2: 614.486622ms v1compat: 1.04033493s
    backoff_delayer_test.go:50: 2 v1: 3.130547176s, v2: 1.334590218s v1compat: 3.396638264s
    backoff_delayer_test.go:50: 3 v1: 6.179228448s, v2: 1.051811511s v1compat: 5.77928712s
    backoff_delayer_test.go:50: 4 v1: 15.570901136s, v2: 1.732785093s v1compat: 8.17296024s
    backoff_delayer_test.go:50: 5 v1: 16.455637376s, v2: 29.972855507s v1compat: 31.336787296s
    backoff_delayer_test.go:50: 6 v1: 59.21714048s, v2: 31.657227726s v1compat: 58.198323904s
    backoff_delayer_test.go:50: 7 v1: 1m43.773947776s, v2: 1m11.670377553s v1compat: 1m15.3597696s
    backoff_delayer_test.go:50: 8 v1: 3m36.747534848s, v2: 1m37.819041046s v1compat: 3m49.018367744s
    backoff_delayer_test.go:50: 9 v1: 2m50.697625038s, v2: 5m0s v1compat: 2m38.656766119s
    backoff_delayer_test.go:50: 10 v1: 4m40.916392857s, v2: 5m0s v1compat: 3m28.969223793s
    backoff_delayer_test.go:50: 11 v1: 4m17.995135785s, v2: 5m0s v1compat: 4m47.037472686s
    backoff_delayer_test.go:50: 12 v1: 3m53.34946784s, v2: 5m0s v1compat: 4m33.770366422s
    backoff_delayer_test.go:50: 13 v1: 3m18.539131104s, v2: 5m0s v1compat: 4m6.71272367s
    backoff_delayer_test.go:50: 14 v1: 2m49.69223906s, v2: 5m0s v1compat: 2m35.579667077s
    backoff_delayer_test.go:50: 15 v1: 3m15.98890724s, v2: 5m0s v1compat: 4m17.281210421s
    backoff_delayer_test.go:50: 16 v1: 4m26.116322953s, v2: 5m0s v1compat: 4m7.342854914s
    backoff_delayer_test.go:50: 17 v1: 2m44.992429212s, v2: 5m0s v1compat: 3m48.280339071s
    backoff_delayer_test.go:50: 18 v1: 4m2.860521763s, v2: 5m0s v1compat: 4m49.059222349s
    backoff_delayer_test.go:50: 19 v1: 4m21.863376382s, v2: 5m0s v1compat: 4m18.762546755s
    backoff_delayer_test.go:50: 20 v1: 4m57.701482934s, v2: 5m0s v1compat: 3m39.716699102s
    backoff_delayer_test.go:50: 21 v1: 3m23.389512787s, v2: 5m0s v1compat: 4m32.289443058s
    backoff_delayer_test.go:50: 22 v1: 4m53.545969272s, v2: 5m0s v1compat: 3m47.839686975s
    backoff_delayer_test.go:50: 23 v1: 4m28.165528471s, v2: 5m0s v1compat: 3m26.263337444s
    backoff_delayer_test.go:50: 24 v1: 2m34.145524452s, v2: 5m0s v1compat: 3m6.272179475s
--- PASS: TestBackoffDelayer (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/conns	10.017s
        --- PASS: TestAccConfigService_serial/ConfigRule/ownerAws (101.75s)
        --- PASS: TestAccConfigService_serial/ConfigRule/customPolicy (114.97s)
        --- PASS: TestAccConfigService_serial/ConfigRule/evaluationMode (110.09s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagValue (110.24s)
        --- PASS: TestAccConfigService_serial/ConfigRule/basic (97.36s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKey (109.39s)
        --- PASS: TestAccConfigService_serial/ConfigRule/scopeTagKeyEmpty (97.51s)
        --- PASS: TestAccConfigService_serial/ConfigRule/tags (126.78s)
        --- PASS: TestAccConfigService_serial/ConfigRule/disappears (98.43s)

Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. client-connections Pertains to the AWS Client and service connections. and removed size/M Managed by automation to categorize the size of a PR. labels May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label May 9, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏲️

@ewbankkit ewbankkit added this to the v5.49.0 milestone May 9, 2024
@ewbankkit ewbankkit merged commit 1609316 into main May 9, 2024
34 checks passed
@ewbankkit ewbankkit deleted the b-configservice-migrate branch May 9, 2024 20:21
github-actions bot pushed a commit that referenced this pull request May 9, 2024
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-connections Pertains to the AWS Client and service connections. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider: Retry interval differences AWS SDK for Go v1 vs. v2
2 participants