-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added resource and data source for aws ec2 capacity block reservation. #37528
Added resource and data source for aws ec2 capacity block reservation. #37528
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @prabhavpawar 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Thanks Johnson for fixing the issues. Appreciate the help! |
% make testacc TESTARGS='-run=TestAccEC2CapacityBlockOfferingDataSource_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2CapacityBlockOfferingDataSource_ -timeout 360m
=== RUN TestAccEC2CapacityBlockOfferingDataSource_basic
=== PAUSE TestAccEC2CapacityBlockOfferingDataSource_basic
=== CONT TestAccEC2CapacityBlockOfferingDataSource_basic
--- PASS: TestAccEC2CapacityBlockOfferingDataSource_basic (8.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 14.540s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@prabhavpawar thank you for the contribution! 🎉 |
This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds a resource for aws_ec2_capacity_block_reservation and data-source for aws_ec2_capacity_block_offering. With Capacity Blocks, GPU instance capacity is available on future dates, and a Capacity Block can be scheduled to start at a time.
Relations
Closes #35358
References
Capacity Block Docs
Output from Acceptance Testing