Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Implement ListTags for Lightsail resources #37652

Closed
acwwat opened this issue May 23, 2024 · 4 comments · Fixed by #37711
Closed

[Enhancement]: Implement ListTags for Lightsail resources #37652

acwwat opened this issue May 23, 2024 · 4 comments · Fixed by #37711
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lightsail Issues and PRs that pertain to the lightsail service. tags Pertains to resource tagging.
Milestone

Comments

@acwwat
Copy link
Contributor

acwwat commented May 23, 2024

Description

Based on the investigation for #32430 (and a few duplicate issues), we found that key-only tags is handled differently in the Terraform AWS Provider, yet the Lightsail API does not directly provide a ListTags action to support the special handling. With an example that @johnsonaj provided for aws_lightsail_instance, we now have a reference implementation that can be applied to all other Lightsail resources that supports tagging, hence this enhancement request.

Affected Resource(s) and/or Data Source(s)

  • aws_lightsail_bucket
  • aws_lightsail_certificate
  • aws_lightsail_container_service
  • aws_lightsail_database
  • aws_lightsail_disk
  • aws_lightsail_distribution
  • aws_lightsail_key_pair
  • aws_lightsail_lb

Potential Terraform Configuration

resource "aws_lightsail_<type>" "example" {
  ...
  tags = {
    EmptyTag = ""
  }
}

References

#37587

Would you like to implement a fix?

Yes

@acwwat acwwat added the enhancement Requests to existing resources that expand the functionality or scope. label May 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/lightsail Issues and PRs that pertain to the lightsail service. label May 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 23, 2024
@justinretzolk justinretzolk added tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.52.0 milestone May 29, 2024
Copy link

This functionality has been released in v5.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jul 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lightsail Issues and PRs that pertain to the lightsail service. tags Pertains to resource tagging.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants