-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform plugin 1.14.0 crashing #4109
Comments
Hi @Puneeth-n sorry you ran into trouble here. Taking a look right now, but looks related to the Relevant panic log:
|
It appears this is occurring because in the API response from Firehose the CloudWatchLoggingOptions is empty in the S3 description. This has been a source of a large portion of crashes with this resource, but we haven't been able to reproduce it in an acceptance test configuration. Would you be able to provide a sanitized version of your configuration along with what region you're hitting? I can patch what I believe the issue is in the code, but it would be nice to finally know how this happening and ensure it never comes back. |
@bflad Here you go! If you have the patch, let me know. Ill compile the plugin and test it and can give you feedback :) Firehose module###############################################################################
# VARIABLES #
###############################################################################
variable name {}
variable account_id {}
variable region {
default = "eu-west-1"
}
variable destination {
default = "s3"
}
variable s3_configuration {
type = "map"
default = {}
}
variable role_name {}
variable enable {}
###############################################################################
# MAIN #
###############################################################################
resource "aws_kinesis_firehose_delivery_stream" "stream" {
count = "${var.enable}"
name = "${var.name}"
destination = "${var.destination}"
s3_configuration {
role_arn = "${lookup(var.s3_configuration, "role_arn")}"
bucket_arn = "${lookup(var.s3_configuration, "bucket_arn")}"
buffer_interval = "${lookup(var.s3_configuration, "buffer_interval", 60)}"
prefix = "${lookup(var.s3_configuration, "prefix")}"
}
}
data "template_file" "firehose_iam_policy" {
template = "${file("${path.module}/iam_policy.tpl")}"
vars {
account = "${var.account_id}"
region = "${var.region}"
bucket_arn = "${lookup(var.s3_configuration, "bucket_arn")}"
name = "${var.name}"
}
}
resource "aws_iam_role_policy" "firehose_iam_policy" {
count = "${var.enable}"
name = "firehose-policy-${var.name}"
role = "${var.role_name}"
policy = "${data.template_file.firehose_iam_policy.rendered}"
}
Configuration:module "deutschebahn_stream" {
source = "../../terraform_modules/ct-firehose/"
enable = "${var.enable_firehose_data_logs}"
name = "fulfillment-deutschebahn-${var.ct_environment_name}"
destination = "s3"
s3_configuration {
role_arn = "${aws_iam_role.firehose_role_purchase_logs.arn}"
bucket_arn = "${var.production_env ? lookup(var.ct_master_vpc, "purchase_logs_arn") : "arn:aws:s3:::purchase-logs-${var.ct_environment_name}"}"
buffer_interval = 60
prefix = "fulfillment-deutschebahn-${var.ct_environment_name}/"
}
account_id = "${var.account_id}"
role_name = "${aws_iam_role.firehose_role_purchase_logs.name}"
} |
The fix for this has been merged into master and will release with v1.14.1 of the AWS provider, likely tomorrow. |
This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Terraform
0.10.8
Terraform-provider-aws:
1.14.0
my crashlog is 54 MB so attaching gzip here
crash.log.gz
The text was updated successfully, but these errors were encountered: