Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ses_event_destination: Multiple dimensions per CloudWatch destination #5620

Closed
xPiSeaZx opened this issue Aug 21, 2018 · 5 comments · Fixed by #6690
Closed

aws_ses_event_destination: Multiple dimensions per CloudWatch destination #5620

xPiSeaZx opened this issue Aug 21, 2018 · 5 comments · Fixed by #6690
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Milestone

Comments

@xPiSeaZx
Copy link

The aws_ses_event_destination does not appear to support multiple dimensions per CloudWatch Destination.

I am able to add multiple dimensions via the AWS console and it also appears that CloudFormation supports this as well: AWS::SES::ConfigurationSetEventDestination

I have tried various methods for adding additional dimensions, but keep getting the following error message (Examples 1 & 2):
Error: aws_ses_event_destination.cloudwatch-aw: cloudwatch_destination: attribute supports 1 item maximum, config has 2 declared.

Other methods just try and apply 1 dimension to the CloudWatch Destination (Example 3)

Any help/suggestions welcome

Resource Config

Example 1

resource "aws_ses_event_destination" "cloudwatch-aw" {
  name                   = "ics-aw-delivery"
  configuration_set_name = "${aws_ses_configuration_set.ics-aw-stats.name}"
  enabled                = true
  matching_types         = ["bounce", "delivery", "reject", "send"]

  cloudwatch_destination = [
    {
      default_value  = "aw-1"
      dimension_name = "ses:configuration-set"
      value_source   = "messageTag"
    },
    {
      default_value  = "aw-2"
      dimension_name = "ses:source-ip"
      value_source   = "messageTag"
    }
  ]
}

Example 2

resource "aws_ses_event_destination" "cloudwatch-aw" {
  name                   = "ics-aw-delivery"
  configuration_set_name = "${aws_ses_configuration_set.ics-aw-stats.name}"
  enabled                = true
  matching_types         = ["bounce", "delivery", "reject", "send"]

  cloudwatch_destination = {
    default_value  = "aw-1"
    dimension_name = "ses:configuration-set"
    value_source   = "messageTag"
  }

  cloudwatch_destination = {
    default_value  = "aw-2"
    dimension_name = "ses:source-ip"
    value_source   = "messageTag"
  }
}

Example 3

resource "aws_ses_event_destination" "cloudwatch-aw" {
  name                   = "ics-aw-delivery"
  configuration_set_name = "${aws_ses_configuration_set.ics-aw-stats.name}"
  enabled                = true
  matching_types         = ["bounce", "delivery", "reject", "send"]

  cloudwatch_destination = {
    default_value  = "aw-1"
    dimension_name = "ses:configuration-set"
    value_source   = "messageTag"

    default_value  = "aw-2"
    dimension_name = "ses:source-ip"
    value_source   = "messageTag"
  }
}

Terraform Version

Terraform v0.11.7

@bflad bflad added question A question about existing functionality; most questions are re-routed to discuss.hashicorp.com. service/ses Issues and PRs that pertain to the ses service. labels Aug 21, 2018
@xPiSeaZx
Copy link
Author

xPiSeaZx commented Sep 5, 2018

Hi, anybody have any feedback/update on this?

@david-wells-1
Copy link
Contributor

I have also come across this issue with v0.11.8 - am going to submit a PR which resolves the issue

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed question A question about existing functionality; most questions are re-routed to discuss.hashicorp.com. labels Dec 3, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 3, 2018
@bflad
Copy link
Contributor

bflad commented Dec 3, 2018

Support for multiple cloudwatch_destination configuration blocks has been merged and will release with version 1.51.0 of the AWS provider, in the next day or two. 👍

@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Nov 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants