-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove maximum=1 for cloudwatch destination #6690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @david-wells-1 👋 Thanks for submitting this! Could you please also update the existing acceptance testing to include multiple CloudWatch destinations to prevent regressions in the future? e.g. copy pasting this test configuration with a slight update:
@bflad - additional test added as requested for the ses_destination_event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @david-wells-1! 🚀
This Terraform resource is very strange and does not have a Read
implementation. While it doesn't look like the SES API has not changed in this regard from my brief searching, I was able to confirm via the acceptance testing with debug SDK logging that multiple destinations were appropriately set and that the SES API accepted this configuration.
--- PASS: TestAccAWSSESEventDestination_basic (93.89s)
Thanks @bflad |
This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #6689
Fixes #5620
Changes proposed in this pull request:
Output from acceptance testing: