Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dynamodb_table: Support 11/15/2018 Server-Side Encryption enhancements #5637

Closed
ewbankkit opened this issue Aug 21, 2018 · 7 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Aug 21, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Looking at the release notes for AWS SDK v1.15.16:

service/dynamodb: Updates service API and documentation
Added SSESpecification block to update-table command which allows users to modify table Server-> Side Encryption. Added two new fields (SSEType and KMSMasterKeyId) to SSESpecification block used by create-table and update-table commands. Added new SSEDescription Status value UPDATING

Add support for these enhancements to the aws_dynamodb_table resource and data source.

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Aug 21, 2018

@ewbankkit
Copy link
Contributor Author

Potentially adapt some refactoring applied in #5508?

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Aug 22, 2018

Proposed syntax:

Enhance aws_dynamodb_table.server_side_encryption attribute with sse_type and kms_master_key_id nested fields.

For example:

resource "aws_dynamodb_table" "t" {
  name           = "GameScores"

  server_side_encryption {
    enabled           = true
    sse_type          = "KMS"
    kms_master_key_id = "${aws_kms_key.a.id}"
  }
}

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Sep 26, 2018
@ewbankkit ewbankkit changed the title r/aws_dynamodb_table: Support Server-Side Encryption enhancements r/aws_dynamodb_table: Support 11/15/2018 Server-Side Encryption enhancements Nov 16, 2018
@ewbankkit
Copy link
Contributor Author

After the 11/15/2018 announcement this issue has been re-titled to implement these changes.

@reggielamson
Copy link

Do you have a time frame for implementing this by chance?

@ewbankkit
Copy link
Contributor Author

Closed. Replaced by #7498.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
3 participants