Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Migrate from github.com/hashicorp/terraform to github.com/hashicorp/terraform-plugin-sdk #10367

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

bflad
Copy link
Member

@bflad bflad commented Oct 3, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: https://www.terraform.io/docs/extend/plugin-sdk.html

Release note for CHANGELOG:

NOTES

* provider: The underlying Terraform codebase dependency for the provider SDK and acceptance testing framework has been migrated from `github.com/hashicorp/terraform` to `github.com/hashicorp/terraform-plugin-sdk`. They are functionality equivalent and this should only impact codebase development to switch imports. For more information see the [Terraform Plugin SDK page in the Extending Terraform documentation](https://www.terraform.io/docs/extend/plugin-sdk.html).

Updated via:

$ tf-sdk-migrator migrate
$ go1.12 get github.com/terraform-providers/terraform-provider-tls@v2.1.1+incompatible
$ go get github.com/bflad/tfproviderlint@v0.5.0
$ go mod tidy
$ go mod vendor

Output from acceptance testing (provided as a smoke test):

--- PASS: TestAccAWSProvider_Region_AwsCommercial (2.87s)
--- PASS: TestAccAWSProvider_Region_AwsChina (2.88s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.90s)
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.12s)
--- PASS: TestAccAWSProvider_Endpoints (3.15s)

…corp/terraform-plugin-sdk

Reference: https://www.terraform.io/docs/extend/plugin-sdk.html

Updated via:

```console
$ tf-sdk-migrator migrate
$ go1.12 get github.com/terraform-providers/terraform-provider-tls@v2.1.1+incompatible
$ go get github.com/bflad/tfproviderlint@v0.5.0
$ go mod tidy
$ go mod vendor
```

Output from acceptance testing (provided as a smoke test):

```
--- PASS: TestAccAWSProvider_Region_AwsCommercial (2.87s)
--- PASS: TestAccAWSProvider_Region_AwsChina (2.88s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.90s)
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.12s)
--- PASS: TestAccAWSProvider_Endpoints (3.15s)
```
@bflad bflad added dependencies Used to indicate dependency changes. technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 3, 2019
@bflad bflad added this to the v2.32.0 milestone Oct 3, 2019
@bflad bflad requested review from a team October 3, 2019 16:28
@ghost ghost added the size/XXL Managed by automation to categorize the size of a PR. label Oct 3, 2019
@bflad bflad merged commit 98b8b84 into master Oct 3, 2019
@bflad bflad deleted the v-terraform-plugin-sdk branch October 3, 2019 18:16
bflad added a commit that referenced this pull request Oct 3, 2019
bflad added a commit that referenced this pull request Oct 4, 2019
@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants