Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_iam_user: Delete a user's virtual MFA devices when force_destroy is enabled #11040

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions aws/resource_aws_iam_user.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,11 @@ func resourceAwsIamUserDelete(d *schema.ResourceData, meta interface{}) error {
return fmt.Errorf("error removing IAM User (%s) SSH keys: %s", d.Id(), err)
}

if err := deleteAwsIamUserMFADevices(iamconn, d.Id()); err != nil {
if err := deleteAwsIamUserVirtualMFADevices(iamconn, d.Id()); err != nil {
return fmt.Errorf("error removing IAM User (%s) Virtual MFA devices: %s", d.Id(), err)
}

if err := deactivateAwsIamUserMFADevices(iamconn, d.Id()); err != nil {
return fmt.Errorf("error removing IAM User (%s) MFA devices: %s", d.Id(), err)
}

Expand Down Expand Up @@ -326,7 +330,45 @@ func deleteAwsIamUserSSHKeys(svc *iam.IAM, username string) error {
return nil
}

func deleteAwsIamUserMFADevices(svc *iam.IAM, username string) error {
func deleteAwsIamUserVirtualMFADevices(svc *iam.IAM, username string) error {
var VirtualMFADevices []string
var err error

listVirtualMFADevices := &iam.ListVirtualMFADevicesInput{
AssignmentStatus: aws.String("Assigned"),
}
pageOfVirtualMFADevices := func(page *iam.ListVirtualMFADevicesOutput, lastPage bool) (shouldContinue bool) {
for _, m := range page.VirtualMFADevices {
if *m.User.UserName == username {
VirtualMFADevices = append(VirtualMFADevices, *m.SerialNumber)
}
}
return !lastPage
}
err = svc.ListVirtualMFADevicesPages(listVirtualMFADevices, pageOfVirtualMFADevices)
if err != nil {
return fmt.Errorf("Error removing Virtual MFA devices of user %s: %s", username, err)
}
for _, m := range VirtualMFADevices {
_, err := svc.DeactivateMFADevice(&iam.DeactivateMFADeviceInput{
UserName: aws.String(username),
SerialNumber: aws.String(m),
})
if err != nil {
return fmt.Errorf("Error deactivating Virtual MFA device %s: %s", m, err)
}
_, err = svc.DeleteVirtualMFADevice(&iam.DeleteVirtualMFADeviceInput{
SerialNumber: aws.String(m),
})
if err != nil {
return fmt.Errorf("Error deleting Virtual MFA device %s: %s", m, err)
}
}

return nil
}

func deactivateAwsIamUserMFADevices(svc *iam.IAM, username string) error {
var MFADevices []string
var err error

Expand Down
6 changes: 5 additions & 1 deletion aws/resource_aws_iam_user_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ func testSweepIamUsers(region string) error {
return fmt.Errorf("error removing IAM User (%s) SSH keys: %s", username, err)
}

if err := deleteAwsIamUserMFADevices(conn, username); err != nil {
if err := deleteAwsIamUserVirtualMFADevices(conn, username); err != nil {
return fmt.Errorf("error removing IAM User (%s) virtual MFA devices: %s", username, err)
}

if err := deactivateAwsIamUserMFADevices(conn, username); err != nil {
return fmt.Errorf("error removing IAM User (%s) MFA devices: %s", username, err)
}

Expand Down