Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for nil UserName for Virtual MFA devices #11072

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

gdavison
Copy link
Contributor

Checking for Virtual MFA Devices in an account where the root user has an MFA device causes a crash. This is because the root user has no "friendly" user name in the record returned by the AWS API.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11040

Release note for CHANGELOG:

NONE

No CHANGELOG entry because this is an unreleased bug, introduced in #11040

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc\(AWSUser_ForceDestroy_\|AWSIAMPolicyAttachment_Users_RenamedUser\|AWSUserLoginProfile_\|AWSUserGroupMembership_basic\)'

--- PASS: TestAccAWSUserLoginProfile_keybaseDoesntExist (21.78s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (24.89s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (26.31s)
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (26.52s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (27.08s)
--- PASS: TestAccAWSUserLoginProfile_PasswordLength (27.38s)
--- PASS: TestAccAWSUserLoginProfile_notAKey (28.31s)
--- PASS: TestAccAWSUserLoginProfile_keybase (30.40s)
--- PASS: TestAccAWSUserLoginProfile_basic (37.46s)
--- PASS: TestAccAWSIAMPolicyAttachment_Users_RenamedUser (50.23s)
--- PASS: TestAccAWSUserGroupMembership_basic (108.67s)

@gdavison gdavison requested a review from a team November 30, 2019 01:50
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/iam Issues and PRs that pertain to the iam service. labels Nov 30, 2019
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No nil!

@aeschright aeschright removed the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2019
@gdavison gdavison merged commit 963982d into master Dec 2, 2019
@gdavison gdavison deleted the b-deleting-mfa-devices-root-user branch December 2, 2019 17:31
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants