Commits on Jan 23, 2020

1. resource/aws_cloudwatch_log_subscription_filter: Perform eventual con… …

   …sistency retries on update
   
   Previously in the acceptance testing:
   
   ```
   --- FAIL: TestAccAWSCloudwatchLogSubscriptionFilter_RoleArn (81.73s)
       testing.go:640: Step 2 error: errors during apply:
   
           Error: Error updating SubscriptionFilter (tf-acc-test-2641008305567738726) for LogGroup (tf-acc-test-2641008305567738726), message: "Could not deliver test message to specified Kinesis stream. Check if the given kinesis stream is in ACTIVE state.", code: "InvalidParameterException"
   ```
   
   Previously, the resource was only performing eventual consistency retries on creation. Since arguments that are subject to the same eventual consistency issues are updateable, this allows the resource to handle situations where the configuration update should be valid.
   
   Output from acceptance testing:
   
   ```
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_disappears (38.37s)
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_basic (43.35s)
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_disappears_LogGroup (50.76s)
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_Distribution (71.23s)
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_DestinationArn_KinesisStream (82.84s)
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_DestinationArn_KinesisDataFirehose (107.36s)
   --- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_RoleArn (118.09s)
   ```

   

   bflad committed Jan 23, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 7ae3ae7
   • Browse repository at this point

   Copy the full SHA

   7ae3ae7 View commit details

   Browse the repository at this point in the history