New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Service: WorkMail #11958
New Service: WorkMail #11958
Conversation
Once #11893 is merged then we can also add tagging support for WorkMail as it was added in AWS SDK v1.28.10. |
Hi @borisroman 👋 Thank you for submitting this. Can you please also ensure the hashibot configuration is updated? https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-service
behavior "regexp_issue_labeler_v2" "service_labels" {
# ... other configuration ...
label_map = {
# ... other services ...
"service/workmail" = [
"aws_workmail_",
],
# ... other services ...
}
}
behavior "pull_request_path_labeler" "service_labels"
# ... other configuration ...
label_map = {
# ... other services ...
"service/workmail" = [
"**/*_workmail_*",
"**/workmail_*",
],
# ... other services ...
}
} Then this should be good to go. Thanks. |
Hi @bflad I should've mentioned; it's already in the codebase: https://github.com/terraform-providers/terraform-provider-aws/blob/master/.hashibot.hcl#L518 & https://github.com/terraform-providers/terraform-provider-aws/blob/master/.hashibot.hcl#L1185 Hope that resolves your comment. |
@borisroman awesome! Sorry I didn't already know that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @borisroman 🚀
Output from acceptance testing:
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (2.94s)
--- PASS: TestAccAWSProvider_Endpoints (2.98s)
Thanks @bflad ! |
This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Added the WorkMail service according to https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#pull-requests
Community Note
Relates #6430
Release note for CHANGELOG: