Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Service: WorkMail #11958

Merged
merged 1 commit into from Feb 7, 2020
Merged

New Service: WorkMail #11958

merged 1 commit into from Feb 7, 2020

Conversation

borisroman
Copy link
Contributor

Added the WorkMail service according to https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#pull-requests

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6430

Release note for CHANGELOG:

- WorkMail service added

@borisroman borisroman requested a review from a team February 7, 2020 16:14
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. labels Feb 7, 2020
@ewbankkit
Copy link
Contributor

Once #11893 is merged then we can also add tagging support for WorkMail as it was added in AWS SDK v1.28.10.

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 7, 2020
@bflad
Copy link
Member

bflad commented Feb 7, 2020

Hi @borisroman 👋 Thank you for submitting this. Can you please also ensure the hashibot configuration is updated? https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-service

  • In .hashibot.hcl: Add the new service to automated issue and pull request labeling. e.g. with the quicksight service
behavior "regexp_issue_labeler_v2" "service_labels" {
  # ... other configuration ...

  label_map = {
    # ... other services ...
    "service/workmail" = [
      "aws_workmail_",
    ],
    # ... other services ...
  }
}

behavior "pull_request_path_labeler" "service_labels"
  # ... other configuration ...

  label_map = {
    # ... other services ...
    "service/workmail" = [
      "**/*_workmail_*",
      "**/workmail_*",
    ],
    # ... other services ...
  }
}

Then this should be good to go. Thanks.

@borisroman
Copy link
Contributor Author

borisroman commented Feb 7, 2020

@bflad
Copy link
Member

bflad commented Feb 7, 2020

@borisroman awesome! Sorry I didn't already know that.

@bflad bflad added this to the v2.49.0 milestone Feb 7, 2020
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @borisroman 🚀

Output from acceptance testing:

--- PASS: TestAccAWSProvider_Endpoints_Deprecated (2.94s)
--- PASS: TestAccAWSProvider_Endpoints (2.98s)

@bflad bflad merged commit afa3bf7 into hashicorp:master Feb 7, 2020
@borisroman borisroman deleted the feature/workmail branch February 7, 2020 21:34
@borisroman
Copy link
Contributor Author

Thanks @bflad !

@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants