Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS Bugfix - Replica creation with Allocated Storage and IOPS #12548

Merged
merged 6 commits into from Jul 9, 2021
Merged

RDS Bugfix - Replica creation with Allocated Storage and IOPS #12548

merged 6 commits into from Jul 9, 2021

Commits on Jul 8, 2021

  1. RDS Bugfix - Replica creation with Allocated Storage and IOPS 

    Ignore allocated storage while creating a Read Replica

* Fixes Issue hashicorp#12493

Tests:

* The acceptance test (allocatedStorageAndIops that would be previously failing), shows the bug by
setting up a Replica DB with both IOPS and Allocated storage.
* Also Added an acceptance test for Iops modification to confirm code is ok because of the returned error
message in the issue. Didn't show failures previously.

Fix:
* Ignore allocated storage when creating a read replica as this value cannot be different from the primary.
* Update doc to reflect param handling difference.
    @YakDriver
    Corentin Debains authored and YakDriver committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    41c9ab8 View commit details
    Browse the repository at this point in the history

  2. Update aws/resource_aws_db_instance.go 

    Co-Authored-By: Muffy Barkocy <muffybarkocy@gmail.com>
    @corentone @muffy @YakDriver
    2 people authored and YakDriver committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    7b2203e View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. r/db_instance: Clean up arguments

    @YakDriver
    YakDriver committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    1983631 View commit details
    Browse the repository at this point in the history

  2. tests/r/db_instance: Clean interpolation only

    @YakDriver
    YakDriver committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    abaa2d7 View commit details
    Browse the repository at this point in the history

  3. tests/r/db_instance: Add errorchecks

    @YakDriver
    YakDriver committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    7fefe9f View commit details
    Browse the repository at this point in the history

  4. r/db_instance: Add changelog

    @YakDriver
    YakDriver committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    b565d31 View commit details
    Browse the repository at this point in the history