Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rd/customer_gateway - add arn + validations #13611

Merged
merged 7 commits into from Jun 23, 2020
Merged

rd/customer_gateway - add arn + validations #13611

merged 7 commits into from Jun 23, 2020

Commits on Jun 4, 2020

  1. add arn attribute + validation for bgp_asn, ip_address, type 

    read after create, refactor errors
add tags + disappears tests
    @DrFaust92
    DrFaust92 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    3feafaa View commit details
    Browse the repository at this point in the history

  2. fix docs

    @DrFaust92
    DrFaust92 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ff370d6 View commit details
    Browse the repository at this point in the history

  3. fix docs + tests

    @DrFaust92
    DrFaust92 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    40643fa View commit details
    Browse the repository at this point in the history

  4. add to docs

    @DrFaust92
    DrFaust92 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ea8be57 View commit details
    Browse the repository at this point in the history

  5. use randIntRange

    @DrFaust92
    DrFaust92 committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    ad5bbb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Apply suggestions from code review 

    if `bgp_asn` can be from 1 to 65534, should i change the tests as well to accommodate for this range?

Co-authored-by: Brian Flad <bflad417@gmail.com>
    @DrFaust92 @bflad
    DrFaust92 and bflad committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    40875c4 View commit details
    Browse the repository at this point in the history

  2. go fmt + sdk wrappers

    @DrFaust92
    DrFaust92 committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    bc7b94e View commit details
    Browse the repository at this point in the history