Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws Config Remediation #13884

Merged
merged 25 commits into from
Sep 16, 2020
Merged

Commits on Jun 19, 2020

  1. feature(config): manage AWS Config Remediation Configuration

    Answering hashicorp#7972
    This is my 1st go development ever, so please feel free to tell me if I
    did something in a bad way, which is most probable :)
    
    feat(go): learn pointers usage
    
    feat(config): parse all simple fields
    
    chore(naming): replace ConfigRule by RemediationConfiguration
    
    feat(config): add read flatten function
    
    feat(config): add delete function
    
    feat(config): use TypeSet instead of TypeList, & parse ResourceValue
    
    feat(config): parse StaticValue
    
    feat(config) flatten remediation config parameters to nil, just to get the function signature right
    
    feat(config): flatten remediation config parameters
    Patrick Laxton authored and cgetzen committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    8df05f1 View commit details
    Browse the repository at this point in the history
  2. feat(tests): write unit tests

    chore(tidy): remove unused import comments
    
    test(config): copy-paste config rule test to start from something
    
    feat(test): add shredder
    
    feat(config): add a remediation configuration exemple
    
    feat(test): add getter check
    
    feat(config): add 1st finished acc test
    
    feat(test): remove unadapted commented tests & add a second true test
    
    feat(test): add static values tests
    
    chore(fmt): format the file with make fmt
    
    fixup! chore(fmt): format the file with make fmt
    
    fix(test): add required on fields
    
    chore(lint): proceed with linter results
    
    chore(lint): use correct configuration
    Patrick Laxton authored and cgetzen committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    7bb7d31 View commit details
    Browse the repository at this point in the history
  3. feedback(pr): 1st lot

    andy-b-84 authored and cgetzen committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    06a307b View commit details
    Browse the repository at this point in the history
  4. feedback(pr): 2nd lot

    andy-b-84 authored and cgetzen committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    d3d3b17 View commit details
    Browse the repository at this point in the history
  5. feedback(pr): 3rd lot

    andy-b-84 authored and cgetzen committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    604c6a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. update to recent version

    cgetzen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    5cb06a2 View commit details
    Browse the repository at this point in the history
  2. documentation

    cgetzen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    b9d6c0c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Update aws/resource_aws_config_remediation_configuration.go

    Terraform plugin SDK v2
    
    Co-authored-by: Graham Davison <g.m.davison@computer.org>
    cgetzen and gdavison committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    834e417 View commit details
    Browse the repository at this point in the history
  2. Update aws/resource_aws_config_remediation_configuration.go

    Wrap AWS API error
    
    Co-authored-by: Graham Davison <g.m.davison@computer.org>
    cgetzen and gdavison committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    327b183 View commit details
    Browse the repository at this point in the history
  3. Update aws/resource_aws_config_remediation_configuration.go

    Remove double read
    
    Co-authored-by: Graham Davison <g.m.davison@computer.org>
    cgetzen and gdavison committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    4ae7afa View commit details
    Browse the repository at this point in the history
  4. Update aws/resource_aws_config_remediation_configuration_test.go

    Terraform Plugin SDK v2
    
    Co-authored-by: Graham Davison <g.m.davison@computer.org>
    cgetzen and gdavison committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    943e342 View commit details
    Browse the repository at this point in the history
  5. Update aws/resource_aws_config_remediation_configuration_test.go

    resourceName
    
    Co-authored-by: Graham Davison <g.m.davison@computer.org>
    cgetzen and gdavison committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    44b08d0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3390d4c View commit details
    Browse the repository at this point in the history
  7. Merge branch 'master' of github-personal.com:terraform-providers/terr…

    …aform-provider-aws into f-aws_config_remediation
    charliegetzen-okta committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    8bf3715 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d8b7e6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5afda14 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Configuration menu
    Copy the full SHA
    7073583 View commit details
    Browse the repository at this point in the history
  2. Add test for recreation

    cgetzen committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    57a4373 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Add test for updates

    cgetzen committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    93f95b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. All acceptance tests pass

    cgetzen committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    5b2973c View commit details
    Browse the repository at this point in the history
  2. linting terraform

    cgetzen committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    57fe47e View commit details
    Browse the repository at this point in the history
  3. linting go

    cgetzen committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    ae16b2c View commit details
    Browse the repository at this point in the history
  4. linting go (2)

    cgetzen committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    f6e73d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Configuration menu
    Copy the full SHA
    2739db6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7399705 View commit details
    Browse the repository at this point in the history