resource/aws_dynamodb_table: Return error instead of panic on empty CreateTable response #13925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reateTable response Reference: #13673 Was not able to reproduce the original crash report on LocalStack 0.11.2, but this will at least prevent the panic in the future. Output from acceptance testing: ``` --- PASS: TestAccAWSDynamoDbTable_basic (36.98s) ```
bflad
added
bug
ghost
added
size/XS
anGie44
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Nice, LGTM 👍
Output of acceptance tests:
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (82.45s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (114.04s)
--- PASS: TestAccAWSDynamoDbTable_basic (343.36s)
--- PASS: TestAccAWSDynamoDbTable_disappears (243.54s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (380.50s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (381.76s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (385.89s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (388.11s)
--- PASS: TestAccAWSDynamoDbTable_tags (389.60s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (401.35s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (401.53s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (408.85s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (338.93s)
--- PASS: TestAccAWSDynamoDbTable_encryption (484.42s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (667.50s)
--- PASS: TestAccAWSDynamoDbTable_extended (669.45s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Single (772.20s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (989.95s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (989.95s)
--- PASS: TestAccAWSDynamoDbTable_Replica_Multiple (1488.70s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (1496.44s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (1711.81s)
c4po
added a commit
to c4po/terraform-provider-aws
that referenced
this pull request
Jun 25, 2020
* origin/master: (59 commits) Update CHANGELOG for hashicorp#13935 resource/aws_batch_compute_environment: Remove resource from Terraform state when not found instead of returning error (hashicorp#13935) resource/aws_dynamodb_table: Return error instead of panic on empty CreateTable response (hashicorp#13925) Update CHANGELOG for hashicorp#13918 New Data Source: aws_efs_access_points (hashicorp#13918) tests/resource/aws_instance: Ensure sweeper has dependencies on resources that manage EC2 Instances (hashicorp#13917) Update CHANGELOG for hashicorp#13937 Update CHANGELOG for hashicorp#5448 resource/aws_cloudtrail: Handle single event selector in cloudtrail with non-default read_write_type (hashicorp#5448) Update CHANGELOG for hashicorp#13892 correct retry message to match in error handling correct import resource name accept empty string in volume_type validation Update CHANGELOG for hashicorp#4855 resource/aws_batch_compute_environment: Support fully optional desired_vcpus and wait for updates add retry error handling for SLR remove unused WebACL resource name in disappears test reference current AWS partition in iam role policy stmt remove duplicated disappears test step Update CHANGELOG for hashicorp#13926 ...
|
This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
Closed
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #13673
Release note for CHANGELOG:
Was not able to reproduce the original crash report on LocalStack 0.11.2, but this will at least prevent the panic in the future.
Output from acceptance testing: