Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_sns_topic_subscription: Add redrive_policy argument #14800

Closed
wants to merge 1 commit into from

Conversation

Ricool06
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10931

Release note for CHANGELOG:

resource_aws_sns_topic_subscription: add `redrive_policy` argument.

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopicSubscription_redrivePolicy'

==> Checking that code complies with gofmt requirements...

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicSubscription_redrivePolicy -timeout 120m

=== RUN   TestAccAWSSNSTopicSubscription_redrivePolicy

=== PAUSE TestAccAWSSNSTopicSubscription_redrivePolicy

=== CONT  TestAccAWSSNSTopicSubscription_redrivePolicy

--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (182.14s)

PASS

ok      github.com/terraform-providers/terraform-provider-aws/aws       185.013s

@Ricool06 Ricool06 requested a review from a team August 24, 2020 14:17
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/sns Issues and PRs that pertain to the sns service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 24, 2020
Copy link

@gmox gmox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@abhi-dwivedi
Copy link

Any update on this

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Feb 6, 2021
@anGie44
Copy link
Contributor

anGie44 commented Feb 6, 2021

Hi @Ricool06 -- thank your contributions...and patience! this looks like a duplicate of #11770 so i'm going to close this one and have a look over there as it's garnered more of a following over time given the reacts 👍

@anGie44 anGie44 closed this Feb 6, 2021
@ghost
Copy link

ghost commented Mar 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/sns Issues and PRs that pertain to the sns service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource aws_sns_topic_subscription, new argument redrive_policy
4 participants