Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GuardDuty filter resource #14876

Merged
merged 70 commits into from Sep 2, 2020
Merged

Add GuardDuty filter resource #14876

merged 70 commits into from Sep 2, 2020

Commits on Jul 7, 2020

  1. Merge pull request #2 from terraform-providers/master 

    Merging master into feature branch
    @graffzon
    graffzon committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    dd41a64 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Added a partially copied, partially corrected resource file

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    af118c7 View commit details
    Browse the repository at this point in the history

  2. Fixed or workarounded syntax errors

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    70d99dd View commit details
    Browse the repository at this point in the history

  3. Made Create action uncommented and not crashing

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    622fe20 View commit details
    Browse the repository at this point in the history

  4. Made Create action to make its way to the API request

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8852d14 View commit details
    Browse the repository at this point in the history

  5. Added tags field for creation

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    6f7535a View commit details
    Browse the repository at this point in the history

  6. Fixed tags assignment

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    17e3fb4 View commit details
    Browse the repository at this point in the history

  7. Made create request work for region only condition

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7f22a94 View commit details
    Browse the repository at this point in the history

  8. Implemented DELETE action for filters

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    fc29555 View commit details
    Browse the repository at this point in the history

  9. Filled in finding criteria

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    031b0f1 View commit details
    Browse the repository at this point in the history

  10. Extracted buildFindingCriteria

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e912469 View commit details
    Browse the repository at this point in the history

  11. Changed the format of guard_duty_filter criterion

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7df19eb View commit details
    Browse the repository at this point in the history

  12. Made different sort of conditions work

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    fb5db6f View commit details
    Browse the repository at this point in the history

  13. Added the update action for the guardduty filter

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c8b3284 View commit details
    Browse the repository at this point in the history

  14. Cleaned up the action default and unveiled the update action

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4dfc52c View commit details
    Browse the repository at this point in the history

  15. Added validations for generic cases

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f990e1e View commit details
    Browse the repository at this point in the history

  16. Implemented on-the-flight validation for the conditions

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2fa228f View commit details
    Browse the repository at this point in the history

  17. Cleaned up comments

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    bdba53c View commit details
    Browse the repository at this point in the history

  18. Made Id of GD filter to be a compounded one

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    fd81374 View commit details
    Browse the repository at this point in the history

  19. Moved a function

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    34c8630 View commit details
    Browse the repository at this point in the history

  20. Added import function without the findingCriteria

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    08b50a8 View commit details
    Browse the repository at this point in the history

  21. Gofmt fixes

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    db2daeb View commit details
    Browse the repository at this point in the history

  22. Gofmt with -s fixes

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    bc4ac65 View commit details
    Browse the repository at this point in the history

  23. Implemented a mock of flattening of the finding criteria

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c241f37 View commit details
    Browse the repository at this point in the history

  24. Fixed map with possible conditions

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d4b07c2 View commit details
    Browse the repository at this point in the history

  25. Made import work also for Finding Criteria

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d6e6608 View commit details
    Browse the repository at this point in the history

  26. Dryed up the flattening functions

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    73a737e View commit details
    Browse the repository at this point in the history

  27. Just moved things around

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7432698 View commit details
    Browse the repository at this point in the history

  28. Fixed create/update case where one field can contain more than one co… 

    …ndition
    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2821f87 View commit details
    Browse the repository at this point in the history

  29. Implemented a better error output

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    de0c9b5 View commit details
    Browse the repository at this point in the history

  30. Added tests for GuardDuty filter

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4d10921 View commit details
    Browse the repository at this point in the history

  31. Improved tests

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    124db85 View commit details
    Browse the repository at this point in the history

  32. Added the documentation

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f08993c View commit details
    Browse the repository at this point in the history

  33. Tiny stylefix

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    88a5e3a View commit details
    Browse the repository at this point in the history

  34. Updated the resource to work with the new provider version

    @graffzon
    Kirill Zonov authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    5678e3f View commit details
    Browse the repository at this point in the history

  35. Removed obsolete tests cases

    @graffzon
    graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9b3fdb4 View commit details
    Browse the repository at this point in the history

  36. Add the subcategory "GuardDuty" 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a33fa1e View commit details
    Browse the repository at this point in the history

  37. Add a validator for a minimum length of 3, maximum length of 64 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    88da720 View commit details
    Browse the repository at this point in the history

  38. Add a validator for a maximum length of 512 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a6c803c View commit details
    Browse the repository at this point in the history

  39. Use keyvaluetags package 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    771b217 View commit details
    Browse the repository at this point in the history

  40. Update the fmt.Errorf calls to return the error object itself using t… 

    …he %w directive

#10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    f08db23 View commit details
    Browse the repository at this point in the history

  41. Rephrase an error message 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    3c15feb View commit details
    Browse the repository at this point in the history

  42. Add test to cover updating values 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    647492a View commit details
    Browse the repository at this point in the history

  43. Use resource.TestCheckResourceAttrPair to verify that the correct val… 

    …ue is set

#10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    958a39f View commit details
    Browse the repository at this point in the history

  44. Add test for finding_criteria 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e8792bf View commit details
    Browse the repository at this point in the history

  45. Fix a lint error AWSR002 

    https://github.com/terraform-providers/terraform-provider-aws/pull/10676/checks?check_run_id=842275982

https://github.com/terraform-providers/terraform-provider-aws/blob/master/awsproviderlint/passes/AWSR002/README.md

```
AWSR002: missing (keyvaluetags.KeyValueTags).IgnoreConfig()
```
By @suzuki-shunsuke
    @graffzon
    graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a2885f2 View commit details
    Browse the repository at this point in the history

  46. Remove deprecated 'sidebar_current' 

    https://github.com/terraform-providers/terraform-provider-aws/pull/10676/checks?check_run_id=842278427

* bflad/tfproviderdocs#23
* https://github.com/hashicorp/terraform-website#yaml-frontmatter

> sidebar_current (deprecated) — No longer used for anything.
> Omit this from new pages, and feel free to remove it from existing ones.

By @suzuki-shunsuke
    @graffzon
    graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    7da9ed3 View commit details
    Browse the repository at this point in the history

  47. Update aws/resource_aws_guardduty_filter.go

    @gdavison @graffzon
    gdavison authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    d48e8ce View commit details
    Browse the repository at this point in the history

  48. Remove the timeout setting 

    #10676 (comment)

> We only provide custom timeout values when there's a need to allow very long timeouts, such as 45 minutes or longer
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    b0c158e View commit details
    Browse the repository at this point in the history

  49. Fix the error handling 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    0199cf6 View commit details
    Browse the repository at this point in the history

  50. Fix the error handling 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    07490bf View commit details
    Browse the repository at this point in the history

  51. Fix the error handling 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    c4df914 View commit details
    Browse the repository at this point in the history

  52. Replace strings to constants defined in the AWS SDK

    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    cab69c1 View commit details
    Browse the repository at this point in the history

  53. Fix the style in document 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    045fb77 View commit details
    Browse the repository at this point in the history

  54. Simplify flattenFindingCriteria

    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    9094964 View commit details
    Browse the repository at this point in the history

  55. Change pointer 

    #10676 (comment)
#10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    5db310e View commit details
    Browse the repository at this point in the history

  56. Check for too many parts as well 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    fbcd71a View commit details
    Browse the repository at this point in the history

  57. Make test data simple and move the resource under test to the top of … 

    …the configuration

#10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    a120a04 View commit details
    Browse the repository at this point in the history

  58. Use parseImportedId 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    672d35f View commit details
    Browse the repository at this point in the history

  59. Define the function to create the GuardDuty Filter's ID 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    88ea72d View commit details
    Browse the repository at this point in the history

  60. Use aws.StringValue instead of direct pointer manupulation 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    87638fe View commit details
    Browse the repository at this point in the history

  61. Add a variable detectorResourceName 

    #10676 (comment)
    @suzuki-shunsuke @graffzon
    suzuki-shunsuke authored and graffzon committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e313e2b View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Merge branch 'master' into added-guardduty-filter-resource 

    # Conflicts:
#	aws/provider.go
#	website/aws.erb
    @gdavison
    gdavison committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c5486f8 View commit details
    Browse the repository at this point in the history

  2. Handle case when there are no tags set and add more complete tests

    @gdavison
    gdavison committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    a001f20 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Adds update and disappears tests

    @gdavison
    gdavison committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    508424d View commit details
    Browse the repository at this point in the history

  2. Adds tag update ability and ARN output

    @gdavison
    gdavison committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    619c9e5 View commit details
    Browse the repository at this point in the history

  3. Updates Exists function to make API call and return API object

    @gdavison
    gdavison committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    2213310 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Updates filter criteria to match AWS API

    @gdavison
    gdavison committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    bc43990 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Uses RFC 3339 dates for "updatedAt" field

    @gdavison
    gdavison committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    54ab4ff View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2020

  1. Updates from code review

    @gdavison
    gdavison committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    9c8eaf2 View commit details
    Browse the repository at this point in the history