Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_glue_crawler s3_target connection_name #15350

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Sep 25, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15351

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCrawler_S3Target_ConnectionName'
--- PASS: TestAccAWSGlueCrawler_S3Target_ConnectionName (121.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       122.122s
...

@nikhil-goenka nikhil-goenka requested a review from a team September 25, 2020 09:46
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Sep 25, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 25, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Sep 25, 2020
@gdavison gdavison self-assigned this Sep 25, 2020
@gdavison gdavison added this to the v3.9.0 milestone Sep 25, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSGlueCrawler_disappears (81.92s)
--- PASS: TestAccAWSGlueCrawler_S3Target_ConnectionName (88.05s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (90.60s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (96.83s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (97.24s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (136.85s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (141.02s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (142.86s)
--- PASS: TestAccAWSGlueCrawler_Configuration (142.94s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (146.80s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (146.82s)
--- PASS: TestAccAWSGlueCrawler_Description (149.01s)
--- PASS: TestAccAWSGlueCrawler_S3Target (150.46s)
--- PASS: TestAccAWSGlueCrawler_Schedule (164.36s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (173.09s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (174.59s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (175.50s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (176.69s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (178.12s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (179.44s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (100.50s)
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (93.97s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (98.70s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (91.06s)
--- PASS: TestAccAWSGlueCrawler_Tags (101.11s)

@gdavison gdavison merged commit 9dac8ef into hashicorp:master Sep 25, 2020
gdavison added a commit that referenced this pull request Sep 25, 2020
@nikhil-goenka nikhil-goenka deleted the f/aws_glue_crawler-s3-target-connectionName branch September 26, 2020 02:22
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Connection_name in s3_target for glue crawler
2 participants