Fixes errorlint reports for internal packages and data sources A-E

[gdavison]

Fixes errorlint reports for internal packages and data sources A-E.

Relates #15891

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeCommitRepositoryDataSource\|TestAccAWSCallerIdentity\|TestAccDataSourceAwsCognitoUserPools\|TestAccAWSAcmCertificateDataSource\|TestAccAWSCloudFrontDataSourceOriginRequestPolicy\|TestAccDataSourceAwsApiGatewayDomainName\|TestAccAWSAvailabilityZones\|TestAccDataSourceAwsAcmpcaCertificateAuthority\|TestAccDataSourceAwsApiGatewayVpcLink\|TestAccDataSourceAwsApiGatewayApiKey\|TestAccAWSAmiDataSource\|TestAccAWSDataSourceCloudFrontDistribution\|TestAccAWSBackupVaultDataSource\|TestAccAWSDbEventCategories\|TestAccDataSourceAwsApiGatewayResource\|TestAccDataSourceAwsArn\|TestAccAWSDbClusterSnapshotDataSource\|TestAccDataSourceAwsApiGatewayRestApi\|TestAccAWSCloudFormationStack\|TestAccAWSAutoscalingGroups\|TestAccAWSCloudformationExportDataSource\|TestAccAWSCloudwatchLogGroupDataSource\|TestAvailabilityZonesSort\|TestAccAWSCustomerGatewayDataSource\|TestAccAWSBackupSelectionDataSource\|TestAccAWSBackupPlanDataSource\|TestAccDataSourceCloudHsmV2Cluster\|TestAccDataSourceAwsBatchJobQueue'

--- SKIP: TestAccAWSAcmCertificateDataSource_singleIssued (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_multipleIssued (0.00s)
--- SKIP: TestAccAWSAcmCertificateDataSource_noMatchReturnsError (0.00s)
--- PASS: TestAvailabilityZonesSort (0.00s)
--- PASS: TestAccAWSAvailabilityZones_basic (48.19s)
--- PASS: TestAccDataSourceAwsApiGatewayApiKey_basic (49.18s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (48.82s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_basic (50.35s)
--- PASS: TestAccAWSAvailabilityZones_Filter (49.93s)
--- PASS: TestAccDataSourceAwsArn_basic (50.66s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (50.15s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (50.95s)
--- PASS: TestAccAWSAmiDataSource_natInstance (57.99s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (58.17s)
--- PASS: TestAccAWSAmiDataSource_instanceStore (60.02s)
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_basic (60.70s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (62.26s)
--- PASS: TestAccAWSAcmCertificateDataSource_KeyTypes (66.38s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (36.18s)
--- PASS: TestAccAWSAmiDataSource_Gp3BlockDevice (84.99s)
--- PASS: TestAccAWSCallerIdentity_basic (34.80s)
--- PASS: TestAccAWSBackupPlanDataSource_basic (37.47s)
--- PASS: TestAccAWSBackupVaultDataSource_basic (36.30s)
--- PASS: TestAccAWSBackupSelectionDataSource_basic (38.16s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_basic (28.20s)
--- PASS: TestAccAWSCloudFrontDataSourceOriginRequestPolicy_basic (34.56s)
--- PASS: TestAccDataSourceAwsApiGatewayResource_basic (98.18s)
--- PASS: TestAccDataSourceAwsApiGatewayDomainName_basic (99.47s)
--- PASS: TestAccAWSCloudformationExportDataSource_basic (52.75s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_tags (31.88s)
--- PASS: TestAccAWSCodeCommitRepositoryDataSource_basic (32.61s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_retention (33.93s)
--- PASS: TestAccAWSCloudwatchLogGroupDataSource_kms (34.85s)
--- FAIL: TestAccAWSDbEventCategories_basic (21.71s)
--- PASS: TestAccDataSourceAwsCognitoUserPools_basic (41.07s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (43.40s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (39.86s)
--- PASS: TestAccAWSDbEventCategories_sourceType (20.67s)
--- PASS: TestAccAWSCloudformationExportDataSource_ResourceReference (89.42s)
--- PASS: TestAccAWSAutoscalingGroups_basic (143.38s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (90.77s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (91.67s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (18.93s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (15.85s)
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
--- PASS: TestAccDataSourceAwsApiGatewayRestApi_EndpointConfiguration_VpcEndpointIds (162.69s)
--- PASS: TestAccDataSourceAwsBatchJobQueue_basic (111.70s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (43.16s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (44.52s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (47.52s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (49.23s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (51.97s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (21.63s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (31.18s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (51.73s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (35.26s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (116.59s)
--- PASS: TestAccAWSCloudFormationStack_basic (75.75s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (118.98s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (95.28s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (125.83s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (101.81s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterSnapshotIdentifier (172.69s)
--- PASS: TestAccAWSCloudFormationStack_disappears (66.16s)
--- PASS: TestAccAWSCloudFormationStack_yaml (72.07s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (70.79s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterIdentifier (190.23s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (49.93s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (81.89s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (167.80s)
--- PASS: TestAccDataSourceCloudHsmV2Cluster_basic (236.70s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (100.87s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (71.26s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_MostRecent (230.18s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (91.61s)
--- PASS: TestAccAWSCloudFormationStack_withParams (121.37s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (233.60s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (126.62s)
--- PASS: TestAccAWSDataSourceCloudFrontDistribution_basic (310.60s)
--- PASS: TestAccDataSourceAwsApiGatewayVpcLink_basic (701.74s)

TestAccAWSDbEventCategories_basic is a pre-existing failure

[bflad]

Looks good to me

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!