Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws/resource_aws_emr_cluster.go: Filter completed EMR steps from ListSteps API #20871

Merged
merged 9 commits into from
Apr 28, 2022
Merged

aws/resource_aws_emr_cluster.go: Filter completed EMR steps from ListSteps API #20871

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
30591fd
Add step filter to List-Steps API for long running EMR clusters
dsc133 Sep 10, 2021
f1a0f3f
Updating filtered list
dsc133 Sep 10, 2021
439200d
Adding CHANGELOG
dsc133 Sep 10, 2021
00d85b7
Revert "Updating filtered list"
ewbankkit Apr 27, 2022
d116b4b
Revert "Add step filter to List-Steps API for long running EMR clusters"
ewbankkit Apr 27, 2022
676781a
Merge branch 'main' into HEAD
ewbankkit Apr 27, 2022
5e2e5c0
r/aws_emr_cluster: Start to tidy up listing steps.
ewbankkit Apr 28, 2022
b56fdc7
r/aws_emr_cluster: Alphabetize attributes.
ewbankkit Apr 28, 2022
bf2aae9
r/aws_emr_cluster: Add 'list_steps_states' argument.
ewbankkit Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/20871.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release=note:bug
resource/aws_emr_cluster: EMR steps with status 'Completed' are now filtered from ListSteps API
```
15 changes: 14 additions & 1 deletion aws/resource_aws_emr_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,8 +1139,21 @@ func resourceAwsEMRClusterRead(d *schema.ResourceData, meta interface{}) error {
}

var stepSummaries []*emr.StepSummary
states := []string{
"PENDING",
"CANCELLED",
"FAILED",
"CANCEL_PENDING",
"RUNNING",
"INTERRUPTED",
}
var stepStates []*string
for _, v := range states {
stepStates = append(stepStates, &v)
}
ewbankkit marked this conversation as resolved.
Show resolved Hide resolved
listStepsInput := &emr.ListStepsInput{
ClusterId: aws.String(d.Id()),
ClusterId: aws.String(d.Id()),
StepStates: stepStates,
}
err = emrconn.ListStepsPages(listStepsInput, func(page *emr.ListStepsOutput, lastPage bool) bool {
// ListSteps returns steps in reverse order (newest first)
Expand Down