Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates contributing docs for Service Packages #21186

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 6, 2021

Updates documentation to reference functions moved to the acctest package

Relates #20000

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 6, 2021
@YakDriver YakDriver force-pushed the f-yakdriver-refactor-3 branch 3 times, most recently from d5aac3a to c31bdbf Compare October 12, 2021 16:34
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service. labels Oct 12, 2021
@gdavison gdavison force-pushed the svcpkg-docs branch 3 times, most recently from feede2d to 06d2be1 Compare October 13, 2021 18:15
@YakDriver YakDriver force-pushed the f-yakdriver-refactor-3 branch 2 times, most recently from fd52d36 to abd3baf Compare October 14, 2021 17:07
Base automatically changed from f-yakdriver-refactor-3 to main October 14, 2021 19:32
@YakDriver YakDriver self-assigned this Oct 14, 2021
@YakDriver
Copy link
Member

@gdavison Looks like maybe a small rebase is needed.

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@gdavison gdavison merged commit 818669c into main Oct 15, 2021
@gdavison gdavison deleted the svcpkg-docs branch October 15, 2021 17:26
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 15, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants