Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting: Restore Terraform code validation for acceptance tests #21383

Merged
merged 2 commits into from
Oct 20, 2021
Merged

linting: Restore Terraform code validation for acceptance tests #21383

merged 2 commits into from
Oct 20, 2021

Conversation

gdavison
Copy link
Contributor

Restore Terraform code validation for acceptance tests

Relates #20000

@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/databasemigrationservice service/ecs Issues and PRs that pertain to the ecs service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. service/ecs Issues and PRs that pertain to the ecs service. service/rds Issues and PRs that pertain to the rds service. service/databasemigrationservice linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Oct 19, 2021
ewbankkit
ewbankkit approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit de788b9 into main Oct 20, 2021
@gdavison gdavison deleted the svgpkg-acctest-tf-validation branch October 20, 2021 19:50
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 20, 2021
github-actions bot pushed a commit that referenced this pull request Oct 20, 2021
Update CHANGELOG.md for #21383
7fc13cc
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.64.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gdavison @ewbankkit